Repository navigation
[7/10] fix: let keyframed clips take effects and transitions in the toolbar - #255
Merged
Merged
Conversation
This was referenced Oct 26, 2026
Base automatically changed from
derk/sdk-motion-presets-over-keyframes
to
main
October 26, 2026 23:34
dazzatronus
force-pushed
the
derk/sdk-motion-toolbar-presets
branch
from
October 26, 2026 23:34
458a4f0 to
262879b
Compare
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 27, 2026
## [2.29.2](v2.29.1...v2.29.2) (2026-10-27) ### Bug Fixes * apply effect and transition presets over keyframes in preview ([#254](#254)) ([8ee2542](8ee2542)) * capture html5 clips animated only by their markup ([#258](#258)) ([78c88b6](78c88b6)) * default the output frame rate to the render's ([#256](#256)) ([16d560e](16d560e)) * **deps:** use shotstack-canvas 2.14.1 ([#257](#257)) ([8db1111](8db1111)) * hold the first keyframe value and ease gaps like the render ([#253](#253)) ([0039a74](0039a74)) * let keyframed clips take effects and transitions in the toolbar ([#255](#255)) ([a4127fe](a4127fe)) * preview slide effects with the render's distances ([#252](#252)) ([4afc59a](4afc59a))
|
🎉 This PR is included in version 2.29.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The toolbar refused effects and transitions on clips with keyframes, and opacity keyframes on clips with an effect or transition, because the preview couldn't show both at once. With 6/10 it can, so both locks go. A helper with no callers left is removed; it wasn't exported.
Verify:
npm test(2357: +2 tests, one test replaced, nine tests of the removed helper deleted).shuffle*previewsMerge bottom-up, retargeting each PR after its predecessor lands. Since #248 the release workflow skips the release when the merged PR's title starts
[n/m]with n < m, so 1/10 to 9/10 hold, and 10/10 releases the stack as one version.Merge subject:
[7/10] fix: let keyframed clips take effects and transitions in the toolbar. The repo squashes a single-commit PR under its commit message, so type this in the merge dialog.