Repository navigation
[1/10] refactor: give the preset builders their own keyframe type - #249
Merged
Merged
Conversation
This was referenced Oct 26, 2026
|
🎉 This PR is included in version 2.29.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The preset builders get their own keyframe type, an alias of
Tweenfor now, and their annotations point at it. Nothing changes in behaviour. 2/10 widens the type so the builders can carry the render's default curve, which isn't one of the public easings.Verify:
npm test(2311, unchanged).shuffle*previewsMerge bottom-up, retargeting each PR after its predecessor lands. Since #248 the release workflow skips the release when the merged PR's title starts
[n/m]with n < m, so 1/10 to 9/10 hold, and 10/10 releases the stack as one version.Merge subject:
[1/10] refactor: give the preset builders their own keyframe type. The repo squashes a single-commit PR under its commit message, so type this in the merge dialog.