Repository navigation
[2/10] fix: preview transitions with the render's durations, curves and directions - #250
Merged
Merged
Conversation
This was referenced Oct 26, 2026
dazzatronus
force-pushed
the
derk/sdk-motion-transition-timing
branch
from
October 26, 2026 22:48
94d7938 to
c3710d7
Compare
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 26, 2026
## [2.29.1](v2.29.0...v2.29.1) (2026-10-26) ### Bug Fixes * draw the canvas at the screen's pixel density ([#263](#263)) ([bc60a4b](bc60a4b)) * preview shuffle transitions ([#251](#251)) ([abb64b7](abb64b7)) * preview transitions with the render's durations, curves and directions ([#250](#250)) ([85f56b6](85f56b6))
|
🎉 This PR is included in version 2.29.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The preview drifted from the render on several transitions. Slow
slide*andcarousel*ran for 2 s where the render takes 1 s. Curves didn't use the render's default handles, cubic-bezier(0.5, 0, 0.5, 1).zoomhad no blur. Every vertical slide and carousel played upside down, soslideDownpreviewed asslideUp. The preview now uses the render's values.To carry that curve, the builders' keyframe type also accepts
smooth.Verify:
npm test(2329, +18). Checked frame by frame against renders of fade, slide, carousel and zoom.shuffle*previewsMerge bottom-up, retargeting each PR after its predecessor lands. Since #248 the release workflow skips the release when the merged PR's title starts
[n/m]with n < m, so 1/10 to 9/10 hold, and 10/10 releases the stack as one version.Merge subject:
[2/10] fix: preview transitions with the render's durations, curves and directions. The repo squashes a single-commit PR under its commit message, so type this in the merge dialog.