Repository navigation
[6/10] fix: apply effect and transition presets over keyframes in preview - #254
Merged
Merged
Conversation
This was referenced Oct 26, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 27, 2026
## [2.29.2](v2.29.1...v2.29.2) (2026-10-27) ### Bug Fixes * apply effect and transition presets over keyframes in preview ([#254](#254)) ([8ee2542](8ee2542)) * capture html5 clips animated only by their markup ([#258](#258)) ([78c88b6](78c88b6)) * default the output frame rate to the render's ([#256](#256)) ([16d560e](16d560e)) * **deps:** use shotstack-canvas 2.14.1 ([#257](#257)) ([8db1111](8db1111)) * hold the first keyframe value and ease gaps like the render ([#253](#253)) ([0039a74](0039a74)) * let keyframed clips take effects and transitions in the toolbar ([#255](#255)) ([a4127fe](a4127fe)) * preview slide effects with the render's distances ([#252](#252)) ([4afc59a](4afc59a))
|
🎉 This PR is included in version 2.29.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A clip with any visual keyframes previewed without its effect and transitions. Presets now insert their points over the keyframes the way the render does: the effect first, then the in transition, then the out. Each reads the keyframed value at its boundary, and a preset point replaces a user point at the same time. The separate layer that used to combine presets with keyframes is removed, because presets now write into the keyframe curves themselves.
Some static clips change with this, to match the render. Zoom and shuffle add to the clip's scale instead of multiplying it, and a slide effect sets the offset (and the scale, when it has to enlarge).
Not matched yet: the render's one-frame offsets at clip ends, its three box-blur passes on zoom (approximated with a Gaussian), and reveal's 1% overshoot.
Size: 562 lines including tests. The old layer and its tests go in the same change that replaces them, so splitting this would leave a version that composes presets neither way.
Verify:
npm test(2364, +10).shuffle*previewsMerge bottom-up, retargeting each PR after its predecessor lands. Since #248 the release workflow skips the release when the merged PR's title starts
[n/m]with n < m, so 1/10 to 9/10 hold, and 10/10 releases the stack as one version.Merge subject:
[6/10] fix: apply effect and transition presets over keyframes in preview. The repo squashes a single-commit PR under its commit message, so type this in the merge dialog.