Skip to content

fix(pb): clear actor reschedule ts on alloc#4338

Open
MasterPtato wants to merge 1 commit intofix-api-properly-dedup-name-listfrom
fix-pb-clear-actor-reschedule-ts
Open

fix(pb): clear actor reschedule ts on alloc#4338
MasterPtato wants to merge 1 commit intofix-api-properly-dedup-name-listfrom
fix-pb-clear-actor-reschedule-ts

Conversation

@MasterPtato
Copy link
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@MasterPtato MasterPtato requested a review from NathanFlurry March 3, 2026 00:11
@railway-app
Copy link

railway-app bot commented Mar 3, 2026

🚅 Deployed to the rivet-pr-4338 environment in rivet-frontend

Service Status Web Updated (UTC)
frontend-cloud 😴 Sleeping (View Logs) Web Mar 6, 2026 at 9:01 pm
website 😴 Sleeping (View Logs) Web Mar 6, 2026 at 9:20 am
frontend-inspector 😴 Sleeping (View Logs) Web Mar 3, 2026 at 8:26 pm
mcp-hub ✅ Success (View Logs) Web Mar 3, 2026 at 12:13 am
ladle ❌ Build Failed (View Logs) Web Mar 3, 2026 at 12:12 am

@claude
Copy link

claude bot commented Mar 3, 2026

PR Review: fix(pb): clear actor reschedule ts on alloc - This is a focused, correct one-line bug fix. The bug: without this fix, if an actor previously failed allocation and went through the retry/rescheduling path (setting reschedule_ts via compare_retry), a subsequent successful call to allocate_actor_v2 would leave the stale reschedule_ts intact in State. The fix placement before the match on res.status at runtime.rs:481 is correct - clearing unconditionally is appropriate since on a new allocation attempt the previous reschedule timestamp is irrelevant regardless of outcome. Consistent with the compare_retry pattern at runtime.rs:1190. The Cargo.lock removal of indexmap is valid unused-dependency cleanup. Overall: minimal, correctly scoped fix. No concerns.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 3, 2026

More templates

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@4338

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@4338

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@4338

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@4338

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@4338

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@4338

@rivetkit/sqlite-vfs

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sqlite-vfs@4338

@rivetkit/traces

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/traces@4338

@rivetkit/workflow-engine

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/workflow-engine@4338

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@4338

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@4338

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@4338

commit: 19f0e42

@MasterPtato MasterPtato force-pushed the fix-api-properly-dedup-name-list branch from c571c59 to 5950673 Compare March 6, 2026 21:09
@MasterPtato MasterPtato force-pushed the fix-pb-clear-actor-reschedule-ts branch from 175e44f to 5ab4c46 Compare March 6, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant