fix(pb): clear actor reschedule ts on alloc#4338
fix(pb): clear actor reschedule ts on alloc#4338MasterPtato wants to merge 1 commit intofix-api-properly-dedup-name-listfrom
Conversation
|
This change is part of the following stack: Change managed by git-spice. |
|
🚅 Deployed to the rivet-pr-4338 environment in rivet-frontend
|
|
PR Review: fix(pb): clear actor reschedule ts on alloc - This is a focused, correct one-line bug fix. The bug: without this fix, if an actor previously failed allocation and went through the retry/rescheduling path (setting reschedule_ts via compare_retry), a subsequent successful call to allocate_actor_v2 would leave the stale reschedule_ts intact in State. The fix placement before the match on res.status at runtime.rs:481 is correct - clearing unconditionally is appropriate since on a new allocation attempt the previous reschedule timestamp is irrelevant regardless of outcome. Consistent with the compare_retry pattern at runtime.rs:1190. The Cargo.lock removal of indexmap is valid unused-dependency cleanup. Overall: minimal, correctly scoped fix. No concerns. |
c571c59 to
5950673
Compare
175e44f to
5ab4c46
Compare
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: