Conversation
|
🚅 Deployed to the rivet-pr-4324 environment in rivet-frontend
|
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
PR Review - deploy patch with targeted fixes. No blocking issues. gasoline workflow builder bypass method: The implementation is correct. The CannotDispatchFromOpInWorkflow error is always set at construction time (new() with from_workflow=true), so the NOTE saying it disregards earlier errors is misleading since no earlier errors can exist at that point. Consider rephrasing to clarify that subsequent builder errors still propagate normally. The method name, allow(non_snake_case), and TODO referencing RVT-5281 clearly mark this as temporary. guard-core log level downgrade: Downgrading from error to warn is appropriate for connection churn. Pre-existing issue (not introduced by this PR): log messages use format string interpolation instead of structured logging per project conventions. Worth a follow-up cleanup. pegboard serverless receiver missing tags: Good fix. The namespace_id and runner_name tags were missing from workflow dispatch, which is critical for routing and deduplication. NATS noise reduction (ups.rs + traces.rs): Downgrading async_nats::Event::Closed from error to info and adding async_nats=warn to the log filter are both correct. Shutdown-time NATS close is expected behavior, not an error condition. The added comment makes this clear. The serverless receiver tag fix is the most impactful change here. |
|
This change is part of the following stack: Change managed by git-spice. |
8d1ae7d to
cf84ca2
Compare
cf84ca2 to
cb04b98
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: