fix(ups): formalize subjects#4334
Draft
MasterPtato wants to merge 1 commit into02-27-chore_bump_rivetkit_protocol_versionfrom
Draft
fix(ups): formalize subjects#4334MasterPtato wants to merge 1 commit into02-27-chore_bump_rivetkit_protocol_versionfrom
MasterPtato wants to merge 1 commit into02-27-chore_bump_rivetkit_protocol_versionfrom
Conversation
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced Mar 2, 2026
|
🚅 Deployed to the rivet-pr-4334 environment in rivet-frontend
|
|
PR Review: fix(ups): formalize subjects. Overall clean, well-scoped refactor. Issues: (1) No Subject impl for owned String, only for &str and &String. (2) publish_with_backoff takes &impl Subject then immediately calls .as_cow() - cleaner to just take &str. (3) MsgSubject::root() allocates via Cow::Owned on every call - could use Cow::Borrowed if M::subject() returned static str. Minor: Helper struct comment should be a complete sentence per style guide. Positives: spawn error propagation fix in message_async is correct, MsgSubject clone is zero-alloc, subject_cow computed once before chunk loop is good. |
d6bbde2 to
cedca7a
Compare
9501411 to
c8e5674
Compare
This was referenced Mar 3, 2026
cedca7a to
22bbe21
Compare
c8e5674 to
73da062
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: