Skip to content

fix(ups): formalize subjects#4334

Draft
MasterPtato wants to merge 1 commit into02-27-chore_bump_rivetkit_protocol_versionfrom
fix-ups-formalize-subjects
Draft

fix(ups): formalize subjects#4334
MasterPtato wants to merge 1 commit into02-27-chore_bump_rivetkit_protocol_versionfrom
fix-ups-formalize-subjects

Conversation

@MasterPtato
Copy link
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@railway-app
Copy link

railway-app bot commented Mar 2, 2026

🚅 Deployed to the rivet-pr-4334 environment in rivet-frontend

Service Status Web Updated (UTC)
website 😴 Sleeping (View Logs) Web Mar 3, 2026 at 11:44 pm
frontend-inspector 😴 Sleeping (View Logs) Web Mar 3, 2026 at 6:15 pm
frontend-cloud ❌ Build Failed (View Logs) Web Mar 2, 2026 at 8:42 pm
mcp-hub ✅ Success (View Logs) Web Mar 2, 2026 at 8:39 pm
ladle ❌ Build Failed (View Logs) Web Mar 2, 2026 at 8:38 pm

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 2, 2026

More templates

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@4334

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@4334

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@4334

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@4334

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@4334

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@4334

@rivetkit/sqlite-vfs

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sqlite-vfs@4334

@rivetkit/traces

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/traces@4334

@rivetkit/workflow-engine

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/workflow-engine@4334

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@4334

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@4334

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@4334

commit: d0fb826

@claude
Copy link

claude bot commented Mar 2, 2026

PR Review: fix(ups): formalize subjects. Overall clean, well-scoped refactor. Issues: (1) No Subject impl for owned String, only for &str and &String. (2) publish_with_backoff takes &impl Subject then immediately calls .as_cow() - cleaner to just take &str. (3) MsgSubject::root() allocates via Cow::Owned on every call - could use Cow::Borrowed if M::subject() returned static str. Minor: Helper struct comment should be a complete sentence per style guide. Positives: spawn error propagation fix in message_async is correct, MsgSubject clone is zero-alloc, subject_cow computed once before chunk loop is good.

@MasterPtato MasterPtato force-pushed the 02-27-chore_bump_rivetkit_protocol_version branch from d6bbde2 to cedca7a Compare March 3, 2026 00:06
@MasterPtato MasterPtato force-pushed the fix-ups-formalize-subjects branch from 9501411 to c8e5674 Compare March 3, 2026 00:06
@MasterPtato MasterPtato requested a review from NathanFlurry March 3, 2026 00:06
@MasterPtato MasterPtato force-pushed the 02-27-chore_bump_rivetkit_protocol_version branch from cedca7a to 22bbe21 Compare March 6, 2026 02:16
@MasterPtato MasterPtato force-pushed the fix-ups-formalize-subjects branch from c8e5674 to 73da062 Compare March 6, 2026 02:17
@MasterPtato MasterPtato mentioned this pull request Mar 6, 2026
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant