fix(udb): add txn tagging by MasterPtato · Pull Request #4328 · rivet-dev/rivet

MasterPtato · 2026-02-27T23:47:02Z

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

railway-app · 2026-02-27T23:47:12Z

🚅 Deployed to the rivet-pr-4328 environment in rivet-frontend

Service	Status	Web	Updated (UTC)
frontend-cloud	😴 Sleeping (View Logs)	Web	Mar 6, 2026 at 5:35 am
website	😴 Sleeping (View Logs)	Web	Mar 1, 2026 at 1:27 am
frontend-inspector	😴 Sleeping (View Logs)	Web	Feb 28, 2026 at 8:23 pm
ladle	❌ Build Failed (View Logs)	Web	Feb 27, 2026 at 11:49 pm
mcp-hub	✅ Success (View Logs)	Web	Feb 27, 2026 at 11:48 pm

MasterPtato · 2026-02-27T23:47:15Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

chore: bump rivetkit protocol version #4329
fix(udb): add txn tagging #4328 👈 (View in Graphite)
fix(api): make actor destroy wait for ack #4327
chore: flatten runtime config #4326
chore: deploy patch #4324
main

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

claude · 2026-02-27T23:49:07Z

PR Review: fix(udb): add txn tagging

This is a small focused change that adds transaction tagging support to the UniversalDB abstraction layer.

Summary: The PR adds a tag() method to the TransactionDriver trait with a default no-op, and exposes it via Transaction::tag. Neither the Postgres nor RocksDB drivers override the default, so tagging is currently a no-op for both backends.

Observations:

1. No callers in this PR. There are no call sites of txn.tag() anywhere in the codebase. This appears to be infrastructure laid down ahead of actual usage. Context in the PR description about where this will be called and what the tags are used for (throttling, observability, tracing?) would help reviewers.

2. Redundant comment. The comment // No-op unless implemented is self-evident from the default trait method body. Per the project comment conventions, remove it or replace it with something explaining why the default is a no-op.

3. Empty PR description. All checkboxes are unchecked and there is no description of the motivation, context, or test plan. Even for small changes, a one-line explanation helps reviewers.

4. FoundationDB semantics. Since universaldb is modeled after FoundationDB, FDB transaction tags are byte strings used for throttling and priority control. The current &str signature is fine for human-readable tags, but if FDB is eventually a target driver, the semantics should align with FDB's tagging model.

5. Silent no-op. If a future implementor forgets to handle the tag, the no-op silently swallows it. Consider a tracing::debug! log in the default to aid future driver development.

Verdict: The change is mechanically correct and follows existing patterns. Main asks before merging: add a brief PR description explaining the motivation and intended usage; remove the redundant comment or replace it with something explaining the intent; optionally consider a debug log in the default no-op.

pkg-pr-new · 2026-02-27T23:50:30Z

More templates

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@4328

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@4328

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@4328

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@4328

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@4328

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@4328

@rivetkit/sqlite-vfs

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sqlite-vfs@4328

@rivetkit/traces

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/traces@4328

@rivetkit/workflow-engine

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/workflow-engine@4328

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@4328

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@4328

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@4328

commit: a07849a

MasterPtato · 2026-02-28T00:23:16Z

This change is part of the following stack:

chore: deploy patch #4324
- chore: flatten runtime config #4326
  - fix(api): make actor destroy wait for ack #4327
    - fix(udb): add txn tagging #4328 ◀
      - chore: bump rivetkit protocol version #4329
        
        fix(ups): formalize subjects #4334
        
        fix(api): properly dedup name list responses #4337
        
        fix(pb): clear actor reschedule ts on alloc #4338
        
        fix(ups): add metrics #4368

_{Change managed by git-spice.}

MasterPtato requested a review from NathanFlurry February 27, 2026 23:47

railway-app bot had a problem deploying to rivet-frontend / rivet-pr-4328 February 27, 2026 23:47 Failure

MasterPtato mentioned this pull request Feb 27, 2026

chore: deploy patch #4324

Open

11 tasks

This was referenced Feb 27, 2026

chore: flatten runtime config #4326

Open

fix(api): make actor destroy wait for ack #4327

Open

chore: bump rivetkit protocol version #4329

Open

MasterPtato mentioned this pull request Mar 2, 2026

fix(ups): formalize subjects #4334

Draft

11 tasks

MasterPtato force-pushed the 02-27-fix_api_make_actor_destroy_wait_for_ack branch from ec5ffcb to c88c25b Compare March 3, 2026 00:06

MasterPtato force-pushed the 02-27-fix_udb_add_txn_tagging branch from 011705e to 3472163 Compare March 3, 2026 00:06

This was referenced Mar 3, 2026

fix(api): properly dedup name list responses #4337

Open

fix(pb): clear actor reschedule ts on alloc #4338

Open

fix(udb): add txn tagging

e28be75

MasterPtato force-pushed the 02-27-fix_api_make_actor_destroy_wait_for_ack branch from c88c25b to c2fcae4 Compare March 6, 2026 02:16

MasterPtato force-pushed the 02-27-fix_udb_add_txn_tagging branch from 3472163 to e28be75 Compare March 6, 2026 02:16

MasterPtato mentioned this pull request Mar 6, 2026

fix(ups): add metrics #4368

Open

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(udb): add txn tagging#4328

fix(udb): add txn tagging#4328
MasterPtato wants to merge 1 commit into02-27-fix_api_make_actor_destroy_wait_for_ackfrom
02-27-fix_udb_add_txn_tagging

MasterPtato commented Feb 27, 2026

Uh oh!

railway-app bot commented Feb 27, 2026 •

edited

Loading

Uh oh!

MasterPtato commented Feb 27, 2026 •

edited

Loading

Uh oh!

claude bot commented Feb 27, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Feb 27, 2026 •

edited

Loading

Uh oh!

MasterPtato commented Feb 28, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

MasterPtato commented Feb 27, 2026

Description

Type of change

How Has This Been Tested?

Checklist:

Uh oh!

railway-app bot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MasterPtato commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

claude bot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MasterPtato commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

railway-app bot commented Feb 27, 2026 •

edited

Loading

MasterPtato commented Feb 27, 2026 •

edited

Loading

claude bot commented Feb 27, 2026 •

edited

Loading

pkg-pr-new bot commented Feb 27, 2026 •

edited

Loading

MasterPtato commented Feb 28, 2026 •

edited

Loading