All services: align the TZ setting with the service template - #356
Merged
Merged
Conversation
The service template defines TZ=Europe/Amsterdam in .env with a link to
the list of time zones, and passes it on as TZ=${TZ}. A few services
did not follow it.
- Dockge, NewWallpaperWhoDis, Radicale: add the TZ block to .env.
- Open WebUI, Tandoor, RustDesk Server: use the template comment on the
TZ line.
- Gramps Web, Mealie: read TZ from .env instead of a fixed
Europe/Amsterdam in compose.yaml.
Paperless, Picard, and Posterizarr have the same fixed value. #329
already fixes those.
crypt0rr
approved these changes
Oct 2, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The service template defines
TZ=Europe/Amsterdamin.envwith a link to the list of time zones, and passes it on asTZ=${TZ}. 119 of the 122 services already had the.envline. This PR fixes the ones that differed:.envhad noTZ. Added the template block.TZline now has the same comment as the template.compose.yamlnow readsTZfrom.envinstead of a fixedEurope/Amsterdam.Why
A fixed value in
compose.yamlmeans that changingTZin.envhas no effect. The defaults stay the same, so existing installations keep their current time zone.This follows the earlier review request in #247 to keep
TZin line with the template.Not in this PR
TIME_ZONEvariable and is unchanged..envdefinesTZbutcompose.yamldoes not pass it to a container. That includes Dockge, NewWallpaperWhoDis, and Radicale from this PR. A follow-up PR will handle those after checking each image.Testing
docker compose config --quietpasses in all eight service directories.docker compose configresolvesTZtoEurope/Amsterdamfor Gramps Web (both containers) and Mealie, as before. With another value set, that value is passed on.git diff --checkpasses.Not tested: I did not start the stacks. The change only replaces a fixed value with a variable that has the same default.