Update refactor and compose consistency to templates - #283
michaelhodges wants to merge 8 commits into
Conversation
Edit compose files to match template. (volumes, enviroment, restart ect..)
michaelhodges
left a comment
michaelhodges
left a comment
There was a problem hiding this comment.
@crypt0rr
I know this is a lot but it should make it easier for users as they only have to edit .env
Also compose files are now consistant with template
Edit compose files to match template. (volumes, enviroment, restart ect..)
Thank you for the suggestion, will have a look later today, I need to do a small test to make sure this approach doesn't introduce errors. When a pointing variable in the compose is not made available anywhere, I think this by default throws an error. |
|
I'll have a look at this too.
…--
Michael Hodges
On Mon, Apr 27, 2026, 8:48 AM Bart ***@***.***> wrote:
*crypt0rr* left a comment (tailscale-dev/ScaleTail#283)
<#283 (comment)>
@crypt0rr <https://github.com/crypt0rr> I know this is a lot but it
should make it easier for users as they only have to edit .env Also compose
files are now consistant with template
Thank you for the suggestion, will have a look later today, I need to do a
small test to make sure this approach doesn't introduce errors. When a
pointing variable in the compose is not made available anywhere, I think
this by default throws an error.
—
Reply to this email directly, view it on GitHub
<#283 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZM4H2LMK52P4YXZZFVW5T4X4GD3AVCNFSM6AAAAACYBLCZNWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DGMRVGE2DSNZWGM>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
|
Alright, so it created warning lines when variables are present but not set, defaulting to a blank string. In case of actual-budget, the app runs fine. But, if a blank |
|
If an application requires a variable to be set then it requires it and it
should be declared in the .env file.
…--
Michael Hodges
On Wed, Apr 29, 2026, 9:59 AM Bart ***@***.***> wrote:
*crypt0rr* left a comment (tailscale-dev/ScaleTail#283)
<#283 (comment)>
Alright, so it created warning lines when variables are present but not
set, defaulting to a blank string. In case of actual-budget, the app runs
fine. But, if a blank "" is set, and the application expects a value of
some sort, it may break downstream...
$ docker compose config
WARN[0000] The "ACTUAL_HTTPS_KEY" variable is not set. Defaulting to a blank string.
WARN[0000] The "ACTUAL_HTTPS_CERT" variable is not set. Defaulting to a blank string.
name: actualbudget
services:
application:
container_name: app-actual-budget
depends_on:
tailscale:
condition: service_healthy
required: true
environment:
ACTUAL_HTTPS_CERT: ""
ACTUAL_HTTPS_KEY: ""
ACTUAL_PORT: "5006"
ACTUAL_UPLOAD_FILE_SIZE_LIMIT_MB: "20"
ACTUAL_UPLOAD_FILE_SYNC_SIZE_LIMIT_MB: "20"
ACTUAL_UPLOAD_SYNC_ENCRYPTED_FILE_SYNC_SIZE_LIMIT_MB: "50"
PGID: "1000"
PUID: "1000"
TZ: Europe/Amsterdam
healthcheck:
test:
- CMD-SHELL
- node src/scripts/health-check.js
timeout: 10s
interval: 1m0s
retries: 3
start_period: 20s
image: docker.io/actualbudget/actual-server:latest
network_mode: service:tailscale
restart: always
volumes:
- type: bind
source: /home/docker-user/actualbudget/actual-budget-data
target: /data
bind: {}
tailscale:
cap_add:
- net_admin
configs:
- source: ts-serve
target: /config/serve.json
container_name: tailscale-actual-budget
devices:
- source: /dev/net/tun
target: /dev/net/tun
permissions: rwm
environment:
TS_AUTH_ONCE: "true"
TS_AUTHKEY: tskey-auth-k7Q4c1uu[...REDACTED...]7enGxA9P
TS_ENABLE_HEALTH_CHECK: "true"
TS_LOCAL_ADDR_PORT: 127.0.0.1:41234
TS_SERVE_CONFIG: /config/serve.json
TS_STATE_DIR: /var/lib/tailscale
TS_USERSPACE: "false"
hostname: actual-budget
healthcheck:
test:
- CMD
- wget
- --spider
- -q
- http://127.0.0.1:41234/healthz
timeout: 10s
interval: 1m0s
retries: 3
start_period: 10s
image: tailscale/tailscale:latest
networks:
default: null
restart: always
volumes:
- type: bind
source: /home/docker-user/actualbudget/config
target: /config
bind: {}
- type: bind
source: /home/docker-user/actualbudget/ts/state
target: /var/lib/tailscale
bind: {}
networks:
default:
name: actualbudget_default
configs:
ts-serve:
name: actualbudget_ts-serve
content: |
{"TCP":{"443":{"HTTPS":true}},
"Web":{"$${TS_CERT_DOMAIN}:443":
{"Handlers":{"/":
{"Proxy":"http://127.0.0.1:5006"}}}},
"AllowFunnel":{"$${TS_CERT_DOMAIN}:443":false}}
—
Reply to this email directly, view it on GitHub
<#283 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZM4H3QYXKNOVFHQNMGJ2T4YG765AVCNFSM6AAAAACYBLCZNWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DGNBSGIZDQOBYG4>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
We agree on that. However, if an application has a default value of, for instance, |
|
We agree on that. However, if an application has a default value of, for
instance, ”false”, and we set an empty variable that reflects in ””, the
application might behave unexpectedly, right?
This is a good point. And should probably be pointed out somewhere in
documentation.
I assume all these configs were working config? Then as I only moved the
information from the environment variables out of compose to env, it would
be correct to think that they should still work.
—
… Reply to this email directly, view it on GitHub
<#283 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZM4HZZYANU5F72SVMSZ7T4YI4VPAVCNFSM6AAAAACYBLCZNWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DGNBWGA3TCNJYHE>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
|
Hi @michaelhodges, thanks again for this big consistency pass, and sorry it has been waiting so long. In the meantime If you'd still like to continue, here is what would make it reviewable and mergeable (see CONTRIBUTING.md and the current service template):
If you don't have time for this anymore, no worries. Just let us know and we'll close this PR. Thanks! |
3 participants
[Service Name]: [Summary of changes]
Refactor environment variables.
Edit compose to match template formate
Description
Edit compose files so they are consistent with template layout.
Now users should only have to edit .env file to get a container running.
Related Issues
Verification
Checklist
Additional Context