Repository navigation
Refuse a second job open --question while an interview ask is open (#737) - #739
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a94581ae74
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| requestedRecordResult(root, input.question, input.plan, input.now); | ||
| const record = requestedRecordResult(root, input.question, input.plan, input.now); | ||
| // Refuse before attaching or writing; openRecordPublication repeats it under the job lock (#737). | ||
| if (record) await assertNoPendingJobAsk(root, record); |
There was a problem hiding this comment.
Recognize relayed interview answers before refusing the next ask
If the owner answers a published question through the supported interview-answer --owner-chat route, opening the next question now refuses JOB_ASK_PENDING even though the first answer is recorded. interviewAnswerCommand removes pending_options but creates no Review act for a chat answer, while pendingJobAsksForTarget recognizes separately recorded answers only for signoffs (signoffSettlesAsk), not interview picks. Consequently, the previous interview ask remains a blocker, and the printed instruction to ingest it cannot work: the recorded answer has already changed the project hash and removed the pending set required for ingestion. Recognize a valid owner-chat answer bound to the published option set before blocking subsequent question or plan publication.
AGENTS.md reference: AGENTS.md:L23-L29
Useful? React with 👍 / 👎.
|
Tower ruling on the Codex P1 (src/job-runtime.ts:83): adopted. A relayed |
) A record publication supersedes every pending ask on the job, and Review drops an answer to a superseded ask, so four --question opens a few seconds apart kept only the last answer. job open --question/--plan now runs the same JOB_ASK_PENDING check the bound writers use: before attaching, and again under the job lock before enqueueing. Re-opening the same option set is still allowed. The refusal names the pending ask and `rig-create job acts <dir> --wait`. next names the one-question-at-a-time loop on each interview-picks job open move, and later questions in the same report wait for the earlier act. Co-Authored-By: Roa <342598975+fj-roa[bot]@users.noreply.github.com>
interview-answer --owner-chat records the answer and clears the pending set but creates no Review act, so the published interview-picks ask blocked the next --question or --plan with JOB_ASK_PENDING forever. Settle that ask, as signoffSettlesAsk does for signoffs, when the question's current answer is an owner-chat answer bound to the published option set (path, sha256 and the set id they resolve to). An un-ingested act for the ask still blocks. Co-Authored-By: Roa <342598975+fj-roa[bot]@users.noreply.github.com>
d631768 to
cb3f5fe
Compare
Closes #737. A second
job open --questiononto a job with a pending interview ask no longer silently replaces the ask: it refusesJOB_ASK_PENDING.Measured first: the pinned host can only take the refusal
Review 4.9.1 carries one option set per record publication, and asks only on the head publication (
JOB_ACT_SOURCE_STALEotherwise). Every publish marks all pending askssuperseded.ask-batchbatches only the subjects of one head. Several interview asks with separate acts are #558's one-page publication. A real-host test on base showed that the second--questionpublished, superseded the first ask, and printed nothing.Change
refusePendingJobAsksinsrc/job-close.ts. It holds the existingassertNoPendingJobAskbody, moved, not copied. Its target widens from a package selector toJobSelector | RecordResult(sameTargetinsrc/job-acts.ts). No new code: theJOB_ASK_PENDINGrow in docs/CHECKS.md now coversjob open --question/--plan.job open --question/--planruns the check before attaching, so nothing is written on refusal, and again under the job lock before enqueueing.rig-create job acts <dir> --wait, then ingest, then re-run.nextat the rigging interview names the loop: publish one question,job acts --json --wait, ingest, then the next question. Later questions read "only after the<first>act is ingested".Verification
bun test tests/job-acts.test.ts -t '#737'--questionrefuses with the whole root byte-identical, and refuses again while the first answer is un-ingested. The first act arrives and is ingested, then the second publishes and its act arrives. Plus thenextloop text.#690fails identically on base on this Mac (a symlink in the temp dir) and passes on Nova.typecheck && lint && bun testinterview --check --jsonandnext --jsonon 9 cloned pilot records, base vs headNotes (not in this PR)
job open --draft/--rigpublishes without this check, so it can also supersede a pending interview ask. It needs its own card.job actsprinting no acts was read as "unanswered", and the owner was asked again. That is job acts with nothing pending: say what was already ingested, so empty is never read as unanswered #738, in flight separately.🤖 Generated with Claude Code