Skip to content

Refuse job open --draft/--rig while an ask is open (#740) - #745

Merged
firejune merged 1 commit into
mainfrom
jinni/740-draft-rig-ask-pending
Nov 20, 2026
Merged

firejune merged 1 commit into
mainfrom
jinni/740-draft-rig-ask-pending

Conversation

@firejune

Copy link
Copy Markdown
Contributor

Closes #740. job open --draft / --rig now refuses JOB_ASK_PENDING while another ask is open on the job, through the same refusePendingJobAsks that #739 added. Publishing a draft or rig would otherwise supersede an interview ask and lose the owner's answer.

Change

  • src/job-runtime.ts: the pre-attach check now covers every job open target (record, rig or draft), with one call.
  • src/job-host.ts: openDraftPublication repeats the check under the job lock before enqueueing, as openRecordPublication does.
  • No second check and no new code. The JOB_ASK_PENDING row in CHECKS.md and the LIVE-REVIEW.md line now say job open.

Intentional supersession: measured, none found

The runner read the writers (job-writer, drafts, rig-version, direction-writers, job-advance, republish), next, LIVE-REVIEW.md and the tests. No flow publishes a draft or rig over a pending ask of another kind on purpose. Bound draft writers already defer on JOB_ASK_PENDING (job-writer.ts:194). The existing draft-over-unanswered-earlier-draft pass in pendingJobAsksForTarget is unchanged.

Verification

Command Exit Result
bun test tests/job-acts.test.ts -t '#740' (tower re-run) 0 3 pass: --draft and --rig refuse while an interview ask is open, keep its answer, and publish after ingest; a draft republished over its unanswered earlier-draft ask still publishes, while an un-ingested earlier-draft act refuses
bun run typecheck · bun run lint 0 · 0
Nova bun test (runner) 0 3175 pass, 3 skip, 0 fail, 149 files
preflight: interview --check --json and next --json on 9 cloned pilot records, main 9614402 vs head (runner and tower) 18/18 byte-identical

Note: a plain job open with no --draft, which opens the current draft in parts or parts-review, has no target before attaching. Its refusal comes from the under-lock check, after attach.

Runner: Jinni (agy, Argon Medium).

🤖 Generated with Claude Code

Co-authored-by: Jinni <342598851+fj-jinni[bot]@users.noreply.github.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T17:49:21.851265Z fe221a7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@firejune
firejune merged commit 1d50ff0 into main Nov 20, 2026
5 checks passed
@firejune
firejune deleted the jinni/740-draft-rig-ask-pending branch November 20, 2026 18:06
@firejune firejune mentioned this pull request Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

job open --draft / --rig refuses JOB_ASK_PENDING over a pending ask, through the same check

1 participant