Repository navigation
Refuse job open --draft/--rig while an ask is open (#740) - #745
Merged
Merged
Conversation
Co-authored-by: Jinni <342598851+fj-jinni[bot]@users.noreply.github.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #740.
job open --draft/--rignow refusesJOB_ASK_PENDINGwhile another ask is open on the job, through the samerefusePendingJobAsksthat #739 added. Publishing a draft or rig would otherwise supersede an interview ask and lose the owner's answer.Change
src/job-runtime.ts: the pre-attach check now covers everyjob opentarget (record, rig or draft), with one call.src/job-host.ts:openDraftPublicationrepeats the check under the job lock before enqueueing, asopenRecordPublicationdoes.JOB_ASK_PENDINGrow in CHECKS.md and the LIVE-REVIEW.md line now sayjob open.Intentional supersession: measured, none found
The runner read the writers (job-writer, drafts, rig-version, direction-writers, job-advance, republish),
next, LIVE-REVIEW.md and the tests. No flow publishes a draft or rig over a pending ask of another kind on purpose. Bound draft writers already defer onJOB_ASK_PENDING(job-writer.ts:194). The existing draft-over-unanswered-earlier-draft pass inpendingJobAsksForTargetis unchanged.Verification
bun test tests/job-acts.test.ts -t '#740'(tower re-run)--draftand--rigrefuse while an interview ask is open, keep its answer, and publish after ingest; a draft republished over its unanswered earlier-draft ask still publishes, while an un-ingested earlier-draft act refusesbun run typecheck·bun run lintbun test(runner)interview --check --jsonandnext --jsonon 9 cloned pilot records, main 9614402 vs head (runner and tower)Note: a plain
job openwith no--draft, which opens the current draft in parts or parts-review, has no target before attaching. Its refusal comes from the under-lock check, after attach.Runner: Jinni (agy, Argon Medium).
🤖 Generated with Claude Code