Repository navigation
Name already-ingested acts when job acts has nothing pending (#738) - #741
Merged
Merged
Conversation
With nothing pending, job acts printed an empty list, which read as "no answer". It now also reports, as `ingested` in --json and as "already recorded" lines in text, each act on the current publication's asks that project.json already holds: ask id, act id, kind, question or stage, at, and the recorded path. `asked` counts the current asks; the text says how many were ingested or that none were asked. The --wait return carries the same fields and JOB_NEXT_TIMEOUT names them. Co-Authored-By: Roa <342598975+fj-roa[bot]@users.noreply.github.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #738. When
job actshas nothing to ingest, it now names the acts that are already ingested for the current asks, so an emptyactscan't be read as "unanswered". In a pilot, the owner's answer had been ingested and recorded, and the agent readacts: []as no answer and asked again.Change
src/job-acts.ts:ingestedJobActs()finds acts on the current asks that project.json already holds.actMatchesAskand checks the same receipts and signoff sources aspendingJobActs.history[i]row once superseded,signoffs[i], orreview_acts[i]((discarded)for a discard receipt).jobActsTextprints them.src/job-host.ts:listCreateJobActsreturnsingestedandaskedon the plain call and on the--waitreturn. TheJOB_NEXT_TIMEOUTmessage names them too (same code, exit 3).docs/CHECKS.md: the act-listing paragraph and theJOB_NEXT_TIMEOUTrow. No new codes.JSON:
{"jobId":"…","acts":[],"asked":1,"ingested":[{"askId":"…","actId":"…","kind":"interview-picks","question":"motion","subject":"question motion","at":"…","recorded":"interview.waypoints[motion].guide"}]}Text:
job: no un-ingested acts; 1 already ingested for 1 current ask(s) (<act> question motion -> interview.waypoints[motion].guide), then one "already recorded at …; no ingest needed" line per act. With no asks:none asked on the current publication.askedkeeps "none asked" apart from "asked, nothing ingested".next, measured, unchangedOn a live merged-host fixture,
nextoffers--question motiononly whilepending_optionsexists. The ingest clears it, after whichnextoffers no re-ask, andnext --jsonlists the guide underanswers[]with itsat. The test asserts this. The text form ofnextdoes not list answers. That would be a smallformatNextfollow-up if wanted, and it is not in this PR.Verification
bun test tests/job-acts.test.tsbun run typecheck·bun run lintbun testNo pilot-clone preflight was needed: the change adds no refusal and writes nothing to project.json, and
interview --check/nextare untouched.Shares
src/job-acts.tswith #739 (#737), in different regions. Whichever lands second rebases.🤖 Generated with Claude Code