Skip to content

Name already-ingested acts when job acts has nothing pending (#738) - #741

Merged
firejune merged 1 commit into
mainfrom
roa/738-job-acts-names-ingested
Nov 20, 2026
Merged

firejune merged 1 commit into
mainfrom
roa/738-job-acts-names-ingested

Conversation

@firejune

Copy link
Copy Markdown
Contributor

Closes #738. When job acts has nothing to ingest, it now names the acts that are already ingested for the current asks, so an empty acts can't be read as "unanswered". In a pilot, the owner's answer had been ingested and recorded, and the agent read acts: [] as no answer and asked again.

Change

  • src/job-acts.ts: ingestedJobActs() finds acts on the current asks that project.json already holds.
    • It reuses actMatchesAsk and checks the same receipts and signoff sources as pendingJobActs.
    • It names where each act sits: the interview guide answer, its history[i] row once superseded, signoffs[i], or review_acts[i] ((discarded) for a discard receipt).
  • jobActsText prints them.
  • src/job-host.ts: listCreateJobActs returns ingested and asked on the plain call and on the --wait return. The JOB_NEXT_TIMEOUT message names them too (same code, exit 3).
  • docs/CHECKS.md: the act-listing paragraph and the JOB_NEXT_TIMEOUT row. No new codes.

JSON:

{"jobId":"…","acts":[],"asked":1,"ingested":[{"askId":"…","actId":"…","kind":"interview-picks","question":"motion","subject":"question motion","at":"…","recorded":"interview.waypoints[motion].guide"}]}

Text: job: no un-ingested acts; 1 already ingested for 1 current ask(s) (<act> question motion -> interview.waypoints[motion].guide), then one "already recorded at …; no ingest needed" line per act. With no asks: none asked on the current publication. asked keeps "none asked" apart from "asked, nothing ingested".

next, measured, unchanged

On a live merged-host fixture, next offers --question motion only while pending_options exists. The ingest clears it, after which next offers no re-ask, and next --json lists the guide under answers[] with its at. The test asserts this. The text form of next does not list answers. That would be a small formatNext follow-up if wanted, and it is not in this PR.

Verification

Command Exit Result
bun test tests/job-acts.test.ts 0 22 pass
bun run typecheck · bun run lint 0 · 0
Nova bun test 0 3168 pass, 3 skip, 0 fail, 149 files

No pilot-clone preflight was needed: the change adds no refusal and writes nothing to project.json, and interview --check/next are untouched.

Shares src/job-acts.ts with #739 (#737), in different regions. Whichever lands second rebases.

🤖 Generated with Claude Code

With nothing pending, job acts printed an empty list, which read as
"no answer". It now also reports, as `ingested` in --json and as
"already recorded" lines in text, each act on the current publication's
asks that project.json already holds: ask id, act id, kind, question or
stage, at, and the recorded path. `asked` counts the current asks; the
text says how many were ingested or that none were asked. The --wait
return carries the same fields and JOB_NEXT_TIMEOUT names them.

Co-Authored-By: Roa <342598975+fj-roa[bot]@users.noreply.github.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T16:34:14.218226Z 48bf2a5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@firejune
firejune merged commit 2997f70 into main Nov 20, 2026
5 checks passed
@firejune
firejune deleted the roa/738-job-acts-names-ingested branch November 20, 2026 16:50
@firejune firejune mentioned this pull request Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

job acts with nothing pending: say what was already ingested, so empty is never read as unanswered

1 participant