Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
missing-translation-status
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThis pull request corrects Japanese grammar, terminology, punctuation, links, UI labels, and procedural wording across TiDB Dashboard documentation. It changes documentation only. No application code or exported entities changed. ChangesDashboard documentation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~8 minutes Change: Bug fix Merge Risk: 🔵 Low · up to The documentation-only changes preserve the verified translations, but the metric example could mislead readers about component durations; reconcile those values before merging. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
yahonda
changed the title
yahonda
changed the title
…n dashboard-faq/session-share/session-sso
- dashboard-faq.md: fixed a wrong-object mistranslation (deploy
NgMonitoring manually -> deploy TiUP manually) and a dropped verb
ending.
- dashboard-session-share.md: fixed the summary reversing inviter and
invitee roles (both said "招待者" where the second/third should say
"招待された人"), and restored 5 UI button/field labels that were
inconsistently translated into Japanese while a sibling button
("Share Current Session") correctly stayed literal English --
TiDB Dashboard's UI only ships en/zh locale files (no ja), so a real
user always sees these labels in English.
- dashboard-session-sso.md: fixed "SQL-based OIDC sign-on" (should be
"OIDC-based Single Sign-On", both the domain and "Single" were
wrong), "Auth0" garbled to "オーソ0", a dropped し in
デプロイして/アクセス, 2 dropped を particles (repeated 3x/2x across
the Okta/Auth0/Casdoor sections), a dropped は after a link, and an
OIDC Token Issuer/Audience term-pair inconsistency (one translated,
one left English).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…rd-diagnostics-report/statement-details
- dashboard-diagnostics-report.md: fixed a subject/object reversal
(TOTAL_TIME/TOTAL_COUNT are monitoring data from Prometheus, not the
other way around), a severely MT-scrambled Note about Raft KV write
metrics (a metric name misplaced into the wrong clause, the metric
list missing one entry, a truncated word), a fabricated "5th node"
with no basis in EN, an unclosed parenthesis, 3 sites missing the に
particle before なります, 2 more dropped-particle sites found during
review, and a scrambled sentence where two error-name examples
(`TiKV channel full`, `tikv write stall`) were displaced into an
unrelated clause about row comments.
- dashboard-statement-details.md: fixed a dropped negation that
reversed the fast-plan-binding limitation's meaning (from "any
statement type other than these five is unsupported" to a bare list
with no qualifier), a UI button ("Drop") translated into Japanese
while its sibling ("Plan Binding") correctly stayed literal English,
and a stray injected "1" with scrambled clause order.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…rd files - continuous-profiling.md: dropped を before ご覧ください - dashboard-access.md: scrambled word order in a "wrong root password" bullet, 2 dropped を particles - dashboard-cluster-info.md: an untranslated lowercase "tombstone" status inconsistent with its capitalized/literal sibling status names elsewhere in the corpus (pd-control.md, tidb-scheduling.md), and a dropped は topic marker - dashboard-diagnostics-access.md: missing punctuation after a backtick timestamp range (2 sites) - dashboard-diagnostics-usage.md: 転属リーダー (personnel-transfer false friend) for "transferred leaders" (PD Region leader scheduling) - dashboard-intro.md: 6 sites with a dropped を before 参照 (2 sibling sentences in the same file already had it correctly), and the "Search Logs" page name translated into Japanese while every sibling TiDB Dashboard page name in the same file (Key Visualizer, SQL Statements, Slow Queries) stays literal English Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…board files - dashboard-key-visualizer.md: fixed a same-file self-contradiction (色が濃いほど used for BOTH lower and higher traffic; should be 寒色系/暖色系 matching the file's own correct wording elsewhere), 2 metric descriptions rendered as verb phrases inconsistent with sibling noun-phrase items in the same list, and a garbled redundant trailing clause. - dashboard-metrics-relation.md: fixed a fabricated "9th node" ordinal with no basis in EN (likely a misread of the "9070.18" figure), 3 dropped particles (は x2, を x1), and a Get/Cop type-name word order inconsistent with sibling bullets in the same list. - dashboard-monitoring.md: fixed an unclosed parenthesis and a dropped を before ご覧ください. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…board-ops-deploy.md
Fixed 2 sites using として機能する ("functions as") instead of the
file's own consistently-used 提供する ("serves"), matching EN's
consistent use of "serves" throughout, and 4 dropped を particles in
"Replace `X` with..." instructions.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…oard-ops-reverse-proxy.md
Fixed a dropped を before "リバースプロキシとして使用する" (NGINX
site; the HAProxy sibling already had it correctly), a redundant
doubled "for example" marker (例えば...（例）"), 2 dropped を before
"例にとると" ("taking X as an example"), 4 dropped を in "Replace `X`
with..." address-substitution instructions, and a dropped を before
参照 in a cross-reference.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…board-ops-security.md - "SSL Termination" (a networking term) mistranslated as "SSL 終了" (end/finish) -- restored to literal English matching the link text - 3 dropped を particles before ご覧ください - Bold emphasis misplaced onto the wrong word twice: "any" (EN's actual emphasis) rendered as bold "client" instead, and a bold span splitting the middle of "リバースプロキシ" instead of covering "NOT"/"ONLY" as EN does - A broken in-page anchor link using the literal Japanese heading text as the anchor fragment instead of the heading's real English slug Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…files
- dashboard-overview.md: one bullet ("monitor and alert messages")
rendered as a verb sentence, breaking the parallel noun-phrase
structure of its 5 siblings in the same list.
- dashboard-profiling.md: a bold span split the katakana compound
word "オンデマンド" in half.
- dashboard-resource-manager.md: a trailing は particle trapped inside
a bold span, and a dropped を before 持っている after a backtick
privilege name.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…rticle in 4 dashboard files
- dashboard-slow-query.md and top-sql.md: a polite-imperative heading
("...してください") inconsistent with every sibling heading in the
file using plain dictionary form
- top-sql.md: a duplicated "Top Top SQL"
- dashboard-statement-list.md: two EN sentences merged into one
run-on with no punctuation between them
- dashboard-user.md: a dropped を before "デフォルトのロールとして設定"
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
yahonda
force-pushed
the
fix-dashboard-defects
branch
from
September 16, 2026 02:31
de2c432 to
1d7ff5b
Compare
…info.md Up, Down, Unreachable, Leaving, and Unknown are literal instance status names, confirmed against tiup-command-status.md and tiup-component-cluster-display.md (which list these same literal names, untranslated, in their own JA summaries) and against pd-control.md/tidb-scheduling.md's consistent literal treatment of PD store states. Only Tombstone had been fixed in the previous commit; this restores the other four to match, and brings the whole list in line with this same file's own Note paragraph, which already backtick-quotes `Leaving`/`Offline`/`Pending Offline` as literal status values. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Matches the sibling label 正常な時間範囲 right below it, and the な-form already used earlier in the same paragraph (異常な時間帯/ 正常な時間帯). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
"スケジュールが高い" (a schedule being "high") is not natural Japanese -- EN's "the scheduling ... is higher" is about the frequency/amount of scheduling activity, not a schedule itself having a magnitude. Insert 頻度 (frequency) so 高い modifies a noun it can naturally modify. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 4180edbd-60fd-465e-ba4d-d3bf6a82f719
📒 Files selected for processing (24)
dashboard/continuous-profiling.mddashboard/dashboard-access.mddashboard/dashboard-cluster-info.mddashboard/dashboard-diagnostics-access.mddashboard/dashboard-diagnostics-report.mddashboard/dashboard-diagnostics-usage.mddashboard/dashboard-faq.mddashboard/dashboard-intro.mddashboard/dashboard-key-visualizer.mddashboard/dashboard-metrics-relation.mddashboard/dashboard-monitoring.mddashboard/dashboard-ops-deploy.mddashboard/dashboard-ops-reverse-proxy.mddashboard/dashboard-ops-security.mddashboard/dashboard-overview.mddashboard/dashboard-profiling.mddashboard/dashboard-resource-manager.mddashboard/dashboard-session-share.mddashboard/dashboard-session-sso.mddashboard/dashboard-slow-query.mddashboard/dashboard-statement-details.mddashboard/dashboard-statement-list.mddashboard/dashboard-user.mddashboard/top-sql.md
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review.
The heading and one body sentence rendered "TiDB \`root\` user" as "TiDB \`root\`ユーザー" (no particle between the two nouns), while a third sentence in the same file correctly used "TiDBの\`root\`ユーザー". Unify on the の form, which also reads more naturally in Japanese. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…review "トラフィックの多いリージョンも 1つのバケット" could be misread as grouping ALL high-traffic Regions into a single shared bucket. Add それぞれ to clarify that each high-traffic Region gets its own individual bucket (as opposed to low-traffic Regions, many of which are compressed into one shared bucket). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Fixes defects found during a full-corpus JA-vs-EN review of
dashboard/(batch 1 of the ongoing review campaign, 24 files/~90 sites). Highlights:Meaning-changing mistranslations:
dashboard-faq.md: a wrong-object mistranslation ("deploy NgMonitoring manually" mistranslated as "deploy TiUP manually")dashboard-session-share.md: the summary literally had the inviter give the invitation code to the inviter (both said "招待者" where the 2nd/3rd should say "招待された人" = invitee); also restored 5 UI button/field labels inconsistently translated into Japanese — TiDB Dashboard's UI only shipsen/zhlocale files (noja), so a real user always sees these labels in Englishdashboard-session-sso.md: "OIDC-based Single Sign-On" mistranslated as "SQL-based ... sign-on" (both the basis and "Single" were wrong); "Auth0" garbled to "オーソ0"; an OIDC Token Issuer/Audience term-pair inconsistency (one translated, one left English); several dropped particlesdashboard-statement-details.md: a dropped negation that reversed the fast-plan-binding limitation's meaning (from "any statement type other than these five is unsupported" to a bare list with no qualifier); a UI button ("Drop") translated while its sibling ("Plan Binding") stayed literal Englishdashboard-diagnostics-report.md: a subject/object reversal (TOTAL_TIME/TOTAL_COUNT are monitoring data from Prometheus, not the reverse); a severely MT-scrambled Note about Raft KV write metrics (a metric name misplaced into the wrong clause, one metric missing from the list, a truncated word); a fabricated "5th node" with no basis in EN; an unclosed parenthesis; a scrambled sentence where two error-name examples were displaced into an unrelated clauseOther real mistranslations / same-file inconsistencies:
dashboard-key-visualizer.md: a self-contradiction where "色が濃いほど" (the darker the color) was used to describe BOTH lower and higher trafficdashboard-metrics-relation.md: a fabricated "9th node" ordinal (likely a misread of "9070.18"), a Get/Cop type-name word-order inconsistencydashboard-cluster-info.md: an untranslated lowercase "tombstone" status inconsistent with corpus-wide literal/capitalized status names (pd-control.md,tidb-scheduling.md)dashboard-diagnostics-usage.md: 転属リーダー (a personnel-transfer false friend) for "transferred leaders" (PD Region leader scheduling)dashboard-intro.md: the "Search Logs" page name translated into Japanese while every sibling TiDB Dashboard page name in the same file stays literal Englishdashboard-ops-deploy.md: 2 sites using として機能する ("functions as") instead of the file's own consistently-used 提供する ("serves")dashboard-ops-security.md: "SSL Termination" mistranslated as "SSL 終了" (end/finish); bold emphasis misplaced onto the wrong word twice (once splitting the middle of a katakana compound); a broken in-page anchor link using the literal Japanese heading text instead of the real English slugdashboard-overview.md,dashboard-profiling.md,dashboard-resource-manager.md: verb-phrase/noun-phrase and bold-span inconsistencies breaking parallel structure with sibling itemsdashboard-slow-query.md,top-sql.md: a polite-imperative heading inconsistent with every sibling heading in the same file (plain dictionary form); a duplicated "Top Top SQL"dashboard-statement-list.md: two EN sentences merged into one run-on with no punctuation between themAll fixes were individually re-verified against the live file and the EN source (
upstream/release-8.5) before being applied; several (Tombstone status, SSL Termination) were additionally cross-checked against sibling terminology used elsewhere in the corpus.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
🤖 Generated with Claude Code
Summary by CodeRabbit