Skip to content

docs: fix inconsistent duration total in dashboard-metrics-relation.md - #23884

Closed
yahonda wants to merge 1 commit into
pingcap:release-8.5from
yahonda:fix-metrics-relation-total-en
Closed

yahonda wants to merge 1 commit into
pingcap:release-8.5from
yahonda:fix-metrics-relation-total-en

Conversation

@yahonda

@yahonda yahonda commented Sep 16, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Fixes an arithmetic inconsistency in an example in dashboard/dashboard-metrics-relation.md.

The text states: "The total duration of TiDB sending key-value requests is 14745.07 seconds, during which the key-value requests for the Get and Cop types respectively consume 9798.02 seconds and 4946.46 seconds."

9798.02 + 4946.46 = 14744.48, which differs from the stated total of 14745.07 by 0.59 seconds — too large a gap to be a rounding artifact, and the paragraph explicitly defines the total as the sum of these two components. Corrected the total to 14744.48 to match the sum of its own stated parts.

Found via a CodeRabbit review comment on pingcap/docs#23883 while reviewing the Japanese translation, which faithfully mirrors this EN inconsistency (and is intentionally not being changed ahead of this EN fix — the weekly sync will propagate it).

Which TiDB version(s) do your changes apply to? (Required)

  • v8.5 (TiDB 8.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

🤖 Generated with Claude Code

The stated total (14745.07 seconds) for TiDB sending key-value
requests didn't match the sum of its own two stated components
(Get: 9798.02s + Cop: 4946.46s = 14744.48s), a difference too large to
be rounding error. Corrected the total to match the sum of its parts.

Found via a CodeRabbit review comment on pingcap#23883 (the JA
translation faithfully mirrored this EN inconsistency).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 9 seconds.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 2b4c6498-6a62-4ffb-8164-d5c77c9eef6b

📥 Commits

Reviewing files that changed from the base of the PR and between 6acba5d and 9fa6adc.

📒 Files selected for processing (1)
  • dashboard/dashboard-metrics-relation.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot

ti-chi-bot Bot commented Sep 16, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign qiancai for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 16, 2026
@yahonda

yahonda commented Sep 16, 2026

Copy link
Copy Markdown
Member Author

Closing — verified against the actual screenshot referenced right above this text (media/dashboard/dashboard-metrics-relation-relation-example2.png): the real dashboard shows tidb_kv_request: 0.00s (0.00%) of 14745.07s (68.28%), confirming 14745.07 is the correct, real measured value from the dashboard, not a documentation typo. The 0.59s gap vs. the sum of the two child values (9798.02 + 4946.46 = 14744.48) is a genuine artifact of the underlying metrics/measurement, not an authoring error. My original "fix" was wrong — thanks to the user for catching this before merge.

@yahonda yahonda closed this Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant