Repository navigation
feat(robot): jtraj takes joint coordinates only, SE3 arguments raise - #716
Open
petercorke wants to merge 1 commit into
Open
petercorke wants to merge 1 commit into
petercorke wants to merge 1 commit into
Conversation
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| ErrorProne | 1 high |
🟢 Metrics 0 complexity · 0 duplication
Metric Results Complexity 0 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #716 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 143 143
Lines 14269 14266 -3
=====================================
+ Misses 14269 14266 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Robot.jtraj was a quintic trajectory between two joint vectors, with a hack that also accepted SE3 poses and solved the inverse kinematics. IK is never simple (which solution is chosen depends on the solver and its starting point, and it can fail), and the hack never checked for failure: it interpolated silently to an invalid configuration. jtraj(q0, qf, t, qd0=None, qd1=None) is now the method form of rtb.tools.trajectory.jtraj. Passing an SE3 for q0 or qf, deprecated in 1.5.0, raises TypeError with a message saying to solve the IK explicitly. The **kwargs that were forwarded to the IK method are gone, and the arguments, formerly T1 and T2, are now q0 and qf. This is a small incompatible change, released as a feat as is usual for such changes here. It also removes the last caller of Puma560.ikine_a by name. Nothing in the repository, its docs or examples, or RVC3 passed poses. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
petercorke
force-pushed
the
deprecate/jtraj-pose-args
branch
from
October 4, 2026 21:05
b16509d to
02945cd
Compare
3 of 4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Robot.jtrajwas a quintic trajectory between two joint vectors, with a hack that also acceptedSE3poses and solved the inverse kinematics. IK is never simple: which solution is chosen depends on the solver and its starting point, and it can fail. The hack never checked for failure, so it interpolated silently to an invalid configuration, and its**kwargswere forwarded to the IK method, which broke e.g.puma.jtraj(T1, T2, 5, q0=...)with aTypeError.jtraj(q0, qf, t, qd0=None, qd1=None)is now the method form ofrtb.tools.trajectory.jtraj, joint coordinates onlySE3forq0orqf(deprecated in 1.5.0) raisesTypeErrorwith a message that says to solve the IK explicitly and gives the replacement**kwargsforwarded to the IK method are gone, and the arguments, formerlyT1/T2, areq0/qf.. deprecated:: 1.5.0note with the replacement recipe, and aversionchangedPuma560.ikine_aIncompatible change
Robot.jtrajno longer acceptsSE3poses, it raisesTypeError. This is a small incompatible change, committed as afeat(no major version bump), as is usual for such changes here. Nothing in this repository, its docs, examples or the wiki passes poses (they all use the purertb.jtrajfunction with joint vectors), and the same holds for RVC3.Test plan
tests/test_Robot.py,test_trajectory.py,test_DHRobot.py: 142 passedrtb.jtraj,qd0/qd1reach the trajectory,SE3for either argument raisesTypeErrorwith the deprecation message on a DH robot and on an ETS robot, an unexpected keyword raisesTypeErrormainand pass here🤖 Generated with Claude Code