feat(trace-viewer): show screencast frames during playback - #42751
Pavel Feldman (pavelfeldman) merged 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
467a8ea to
7290921
Compare
This comment has been minimized.
This comment has been minimized.
7290921 to
7e4567b
Compare
This comment has been minimized.
This comment has been minimized.
Playback and dragging the scrubber show the screencast at the current time. Stopping, releasing the scrubber, hovering an action or picking a locator snap back to the action snapshot. Traces with a video play the video itself, the thumbnails only index the film strip lanes.
7e4567b to
c7d2d66
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| target={ariaModeTargets[snapshotTab]} | ||
| point={snapshotTab === 'action' ? action?.point : undefined} | ||
| box={snapshotTab === 'action' ? action?.box : undefined} | ||
| screencastFrame={screencastFrame} |
There was a problem hiding this comment.
what if video drifts away from the action and the image is different from the snapshot? may be confusing for the user that stopped on an action
Test results for "tests 1"2 failed 11 flaky52012 passed, 1250 skipped Merge workflow run. |
|
Hi, I'm the Playwright bot and I took a look at the CI failures here. 🟢 CI is clear — both failures are a macOS installation-bot outage
DetailsOverall: 2 failed, 11 flaky in the latest report. Neither failure is attributable to this PR — the Pre-existing flake / infra
Worth a glance, not a failure
Triaged by the Playwright bot - agent run |
Test results for "MCP"5 failed 8624 passed, 1446 skipped Merge workflow run. |
|
Hi, I'm the Playwright bot and I took a look at the CI failures here. 🟡 Six of the seven failures are provable noise — one I can't clearThe two DetailsOverall: 2 failed in "tests 1", 5 failed in "MCP". The diff is confined to Pre-existing flake / infra
Uncertain
Also worth knowing: the PR's own new test Triaged by the Playwright bot - agent run |
0ee695b
into
microsoft:main
Summary