Skip to content

test(coverage): skip coverage tests on tracing bots - #42778

Open
Yury Semikhatsky (yury-s) wants to merge 1 commit into
microsoft:mainfrom
yury-s:fix-coverage-tracing-bots
Open

Yury Semikhatsky (yury-s) wants to merge 1 commit into
microsoft:mainfrom
yury-s:fix-coverage-tracing-bots

Conversation

@yury-s

Copy link
Copy Markdown
Member

Summary

  • The tests start their own tracing, so they fail on tracing bots where every context is already traced.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

2 failed
❌ [installation tests] › playwright-cdn.spec.ts:43 › playwright cdn failover should work (https://cdn.playwright.dev/dbazure/download/playwright) @package-installations-macos-latest
❌ [installation tests] › playwright-cdn.spec.ts:43 › playwright cdn failover should work (https://playwright.download.prss.microsoft.com/dbazure/download/playwright) @package-installations-macos-latest

5 flaky ⚠️ [chromium-library] › library/chromium/chromium.spec.ts:213 › should intercept service worker requests (main and within) `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:373 › should produce network events, routing, and annotations for Service Worker `@chromium-ubuntu-22.04-node22`
⚠️ [chromium-library] › library/popup.spec.ts:260 › should not throw when click closes popup `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`

51997 passed, 1247 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 Both failures are a pre-existing CDN flake — the PR is clear

Hi, I'm the Playwright bot and I triaged the failing CI here.

The two red tests are playwright-cdn.spec.ts:43 CDN failover on package-installations-macos-latest. They fail on unrelated PRs and on main push runs too, and this PR only adds a it.skip to tests/library/coverage.spec.ts — which the installation suite never runs.

Details

Pre-existing flake / infra

  • [installation tests] › playwright-cdn.spec.ts:43 › playwright cdn failover should work (https://cdn.playwright.dev/dbazure/download/playwright) and the sibling (https://playwright.download.prss.microsoft.com/dbazure/download/playwright) — both flake in lockstep. Across the aggregated CI results each one failed 33 of 2783 runs (1.2%) spanning 31 distinct SHAs, including push runs on main and other PRs from the last two days: 35307781325 (push, ebf3a87c), 35289932206 (fix(reporter): fail perfetto writes when the output stream errors #42715), 35294938469 (feat(firefox): roll to r1549 #42767), 35292067119 (feat(trace-viewer): show screencast frames during playback #42751), 35288561056 (feat(reporter): and printOnlyFailures and --reporter-only-failures #42766). The error is always the download step giving up — Expected the command to exit cleanly (0 status code), but exited with 1. Command: npx playwright install … — i.e. the mirror is intermittently unreachable, not a product change. The third variant of the same test, (https://cdn.playwright.dev), has never failed in that window.

    The diff can't reach this: it's a one-line it.skip(({ trace }) => trace === 'on', …) in tests/library/coverage.spec.ts, which is in the library suite and doesn't touch the browser-download path the installation tests exercise.

The 5 flaky tests in the report (service worker interception, popup close, partitioned cookies) are likewise in areas the diff doesn't touch, and they passed on retry.

Triaged by the Playwright bot - agent run

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

2 failed
❌ [firefox] › mcp/annotate.spec.ts:446 › should switch screencast to -s session on show --annotate @mcp-windows-latest-firefox
❌ [firefox] › mcp/cli-session.spec.ts:54 › idle timeout shuts the session down @mcp-windows-latest-firefox

8627 passed, 1446 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 All four failures are known flakes — the PR is clear

Hi, I'm the Playwright bot and I triaged the failing CI here.

This PR adds one it.skip(({ trace }) => trace === 'on') to tests/library/coverage.spec.ts and nothing else. None of the red tests live in that file or run the library suite, and all four flip verdict across runs on SHAs this PR can't reach.

Details

Pre-existing flake / infra

  • [firefox] › mcp/annotate.spec.ts:446 › should switch screencast to -s session on show --annotate @mcp-windows-latest-firefox — failed 76 of 695 runs (11%), passed the other 619. 75 of those failures are on other PRs and main pushes, across 32 distinct PRs. It also trickles on chromium/chrome/msedge Windows and macOS (1–3 failures each), so it's a broad screencast-timing flake, worst on the Firefox Windows bot.

  • [firefox] › mcp/cli-session.spec.ts:54 › idle timeout shuts the session down @mcp-windows-latest-firefox — the flakiest of the group: failed 33 of 101 runs (33%), 32 of them on other PRs spanning 16 distinct PRs. An idle-timeout race on the slowest bot.

  • [installation tests] › playwright-cdn.spec.ts:43 › playwright cdn failover should work (both the cdn.playwright.dev and playwright.download.prss.microsoft.com variants) @package-installations-macos-latest — each failed 33 of 641 runs (5%), 32 elsewhere across 16 distinct PRs. CDN reachability from the macOS installation bot, not code.

Nothing here touches tracing, MCP sessions, or package installation from this diff's side — the only change is a test-level skip guard.

Triaged by the Playwright bot - agent run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants