Repository navigation
fix(lane-transcripts): list the mutation lane's transcript job-ids - #13642
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
claude-security-review reviewed Security review: PR #13642No security issues found. This PR adds one line to What I checked:
Spend: the six added names raise the puller's No CRITICAL findings, so no adversarial refute pass was needed. I read the whole diff: 1 of 1 files, so the review is complete. critical-findings: 0 |
|
claude-review reviewed Code review: no findings. I read the full diff: one changed file, The new
|
… a workflow change (#13925) No related issue: ledger L377 (test selection misses suites that read every workflow), left from #13642, #13645 and #11154 ## Summary `scripts/plan-test-lanes.sh` selected a test package on a workflow change only when one of its suites named that workflow file. Six packages have suites that list `.github/workflows/` and check every workflow, so a change to a workflow no suite names skipped them. For example, `-- .github/workflows/maintenance-delete-stale-branches.yml` selected only branch-cleanup and lane-transcripts on main. ## Fix - `.github/workflows/` is added to resolve-config's SUBPROJECTS line, and OUTSIDE_TRIGGERS rows are added for check-signed-commits, check-wip-cap, log-api-budget, `.github/scripts/lib` and pr-merge. This is the selector's existing mechanism for the same gap (#13658). - A generic scan was not used: a suite that lists the directory names no workflow, and the listing calls vary (a `readdirSync` grep missed `pull.test.mjs`). ## Verification - `scripts/plan-test-lanes.test.sh`: 60 of 60 pass. Against the old planner the extended suite gives 58 pass and 2 fail: "a workflow no suite names runs every package whose suites read every workflow", and the pr-verify.yml case. - Probe after the fix: `-- .github/workflows/maintenance-delete-stale-branches.yml` selects all eight packages. - `selection-audit.test.sh` 20 of 20; the three Node suites that mention the planner 256 of 256; shellcheck clean. ## Related - #13658 added the trigger table rows for the lane-transcripts case of this gap. ## Follow-ups - Pre-existing (advisory): the fix is per package, so a new suite that lists the workflows directory will be missed again, the second time after #13658. A `// test-scope:` declaration for Node suites (affected-tests.sh R8 accepts only `#` comments today) would close it for good. - Pre-existing (advisory): every workflow change now also runs these six packages, including resolve-config's large callers.test.mjs; the added wall time is not measured. session: automation-lanes 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: melodic-automation-lanes[bot] <337595936+melodic-automation-lanes[bot]@users.noreply.github.com>
No related issue: red-main fix for the #13632/#13637 semantic conflict.
Summary
Main at 50dc172 fails
test-node(run 42150021514):scripts/lane-transcripts/pull.test.mjs:212requires every workflow that callsupload-lane-transcriptto be in the puller'sTRANSCRIPT_JOB_IDS. #13637 added that sync test; #13632 then addedpost-merge-test-mutation.yml, which uploads transcripts and is not in the list.Fix
scripts/lane-transcripts/pull.mjs: listpost-merge-test-mutation.ymlwith its six upload job-ids,generateandtriageon the key, subscription and fallback legs (legs("generate"),legs("triage")). Each upload step passesjob-id: ${{ github.job }}(post-merge-test-mutation.ymllines 421, 749, 1035, 1510, 1867, 2182, in jobs generate, generate-subscription, generate-fallback, triage, triage-subscription, triage-fallback).Verification
node --test scripts/lane-transcripts/pull.test.mjs: 32 of 32 pass, including the sync test that fails on main.Related
Follow-ups
test-nodeat the same commit, so select-tests did not pick the lane-transcripts suite for a diff only under.github/workflows/. A test that reads workflow files should be selected when they change, or every new uploader goes red only on main.session: github-support
🤖 Generated with Claude Code