[kyle-sexton]

No related issue: hub follow-up L377 from #13642's Follow-ups (the select-tests gap behind the 2026-11-06 red main).

Summary

scripts/lane-transcripts/pull.test.mjs reads every workflow's upload-lane-transcript calls (pull.test.mjs:189-214), but plan-test-lanes.sh selected the package only for files under scripts/lane-transcripts/. #13632's merge-group run 42147317467 changed only .github/workflows/, skipped the suite, and main went red (fixed by #13642).

Fix

• scripts/plan-test-lanes.sh: scripts/lane-transcripts declares .github/workflows/ as a trigger in OUTSIDE_TRIGGERS, the existing map pr-verify and lane-run-report use to name the workflows their tests read.
• scripts/plan-test-lanes.test.sh: the fixture lists the package; new cases assert any workflow change selects it and a change outside .github/workflows/ does not; two package counts move from 7 to 8.

Verification

• bash scripts/plan-test-lanes.test.sh: PASS=60 FAIL=0.
• Live planner, bash scripts/plan-test-lanes.sh -- .github/workflows/post-merge-test-mutation.yml: node_packages now ends with scripts/lane-transcripts, unmapped=0.

Related

• ci(lanes): run the mutation lane on run-claude-cli, mutants in a job with no secret #13632, fix(lane-transcripts): list the mutation lane's transcript job-ids #13642

🤖 Generated with Claude Code

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	⚠️ Failed 2026-11-06T04:55:36.357744Z We couldn’t complete this review. Comment @codex review to try again.	e3f8d88	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[github-actions]

claude-security-review reviewed e3f8d88f8693bb6e4b60f7e98f267ced6af4dbdd: read 2 of 2 changed file(s); 0 finding(s), 0 as inline comments.

Security review: PR #13658 found no security issues

I read every hunk of both changed files: scripts/plan-test-lanes.sh and scripts/plan-test-lanes.test.sh. Neither file matches a trusted-path glob.

What the change does: it adds one entry to the test planner's OUTSIDE_TRIGGERS map ([scripts/lane-transcripts]=".github/workflows/"). With it, any change under .github/workflows/ also selects the scripts/lane-transcripts Node test package. The rest of the PR updates the planner's own test fixture and assertions: one new case for a workflow change, one negative case, and two package counts that move from 7 to 8.

Security assessment:

• The change only makes the planner select more tests. It skips none and doesn't touch a merge hold, the trusted-trigger check, token scope, the kill switch, or untrusted-text handling.
• No new input reaches a shell. The map value is a fixed literal, and changed file paths are matched against it the same way the existing pr-verify and lane-run-report entries already work.
• It doesn't delete or loosen any instruction, and it doesn't touch a plugin manifest.
• The PR description contains no embedded instructions aimed at the review lane.

Spend: pull requests and merge-group runs that change .github/workflows/ now also run the scripts/lane-transcripts Node test suite. That is a small amount of extra standard-runner Actions time, not a billed resource or plan change.

critical-findings: 0

[github-actions]

claude-review reviewed e3f8d88f8693bb6e4b60f7e98f267ced6af4dbdd: read 2 of 2 changed file(s); 0 finding(s), 0 as inline comments.

Code review: no findings

I read every hunk of both changed files: scripts/plan-test-lanes.sh and scripts/plan-test-lanes.test.sh.

What changed. scripts/lane-transcripts now lists .github/workflows/ as a trigger in OUTSIDE_TRIGGERS. Before this, a change to .github/workflows/ alone did not select that package, even though its pull.test.mjs reads every workflow's upload-lane-transcript calls.

Correctness. I checked the change against the code it feeds:

• Trigger matching (plan-test-lanes.sh#L326-L333). A trigger that ends in / matches by prefix. So .github/workflows/ selects the package for any workflow file and for nothing outside that directory, which is what the PR intends.
• Real package list. scripts/lane-transcripts is already on scripts/outside-node-packages.txt (line 46). The new map entry therefore takes effect through plan-test-lanes.sh#L235.
• Test fixture and assertions. The fixture adds the package to the list. The updated pr-verify.yml assertion, the new any-workflow case (it reuses the pr-unblock.yml plan) and the two count changes from 7 to 8 all follow from the change.
• Negative case. The new test plans .github/actions/check-kill-switch/action.yml. That path is not one of the paths that make the planner run everything (only pr-require-checks.yml and download-full-history/* do, at L151-L159). So the case does test that a change outside the directory leaves the package out.

Closing issue. None. The PR says it is a follow-up to #13642 and states no acceptance criteria, so there is nothing to check against an issue.

Verification. I had no shell, so I did not run anything. The author reports PASS=60 FAIL=0 for bash scripts/plan-test-lanes.test.sh; that result is unverified.

Spend. Every PR that touches .github/workflows/ now also runs the scripts/lane-transcripts Node test suite. That uses standard CI minutes and is not a hold.