Skip to content

ci(test-lanes): run lane-transcripts on any workflow change #13658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyle-sexton merged 1 commit into from
Nov 6, 2026
Merged

ci(test-lanes): run lane-transcripts on any workflow change #13658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scripts/plan-test-lanes.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,7 @@ read_list::into outside "$PACKAGES_LIST" --comments inline || exit 2
declare -A OUTSIDE_TRIGGERS=(
[.github/scripts/pr-verify]=".github/workflows/pr-verify.yml"
[.github/scripts/lane-run-report]=".github/workflows/pr-run-activity-read.yml .github/workflows/pr-run-activity-write.yml .github/scripts/lib/"
[scripts/lane-transcripts]=".github/workflows/"
)

# Every Node package as `<package> <owner> [<trigger>]`.
Expand Down
17 changes: 13 additions & 4 deletions scripts/plan-test-lanes.test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ ERR="$scratch/plan.err"

cp "$REPO_ROOT/scripts/affected-tests-no-suite.txt" "$repo/scripts/"
: >"$repo/scripts/run-plugin-tests-serial.txt"
printf 'plugins/knowledge/vendor/repo-analysis\n.github/scripts/pr-verify\n' >"$repo/scripts/outside-node-packages.txt"
printf 'plugins/knowledge/vendor/repo-analysis\n.github/scripts/pr-verify\nscripts/lane-transcripts\n' >"$repo/scripts/outside-node-packages.txt"
printf 'plugins/fx/evals/fixtures/\n' >"$repo/scripts/outside-node-exclusions.txt"

# mk <path> [<content>]: a fixture file.
Expand Down Expand Up @@ -315,16 +315,25 @@ rc=0
check "a sibling of a trigger file does not run that package" "$rc"

plan -- .github/workflows/pr-verify.yml
is "$(key node_packages)" ".github/scripts/pr-verify" && is "$(key node)" true
is "$(key node_packages)" ".github/scripts/pr-verify scripts/lane-transcripts" && is "$(key node)" true
check "a change to pr-verify.yml alone runs the pr-verify package" $?

plan -- .github/workflows/pr-unblock.yml
rc=0
[[ " $(key node_packages) " != *" .github/scripts/pr-verify "* ]] || rc=1
check "another workflow does not run the pr-verify package" "$rc"

# pull.test.mjs reads every workflow's upload-lane-transcript calls.
is "$(key node_packages)" "scripts/lane-transcripts"
check "any workflow change runs the lane-transcripts package" $?

plan -- .github/actions/check-kill-switch/action.yml
rc=0
[[ " $(key node_packages) " != *" scripts/lane-transcripts "* ]] || rc=1
check "a change outside .github/workflows/ does not run the lane-transcripts package" "$rc"

plan -- .node-version
is "$(key node_packages | wc -w | tr -d ' ')" 7
is "$(key node_packages | wc -w | tr -d ' ')" 8
check "a Node pin runs every Node package" $?

plan -- plugins/ps/x.ps1
Expand Down Expand Up @@ -362,7 +371,7 @@ check "an unmapped shell file runs the whole shell corpus and is counted" $?

plan -- .github/workflows/pr-require-checks.yml
is "$(key bash_legs)" "[0,1,2,3,4,5,6,7,8,9,10,11]" && is "$(suites bash | wc -l | tr -d ' ')" 12 &&
is "$(suites python | wc -l | tr -d ' ')" 2 && is "$(key node_packages | wc -w | tr -d ' ')" 7 &&
is "$(suites python | wc -l | tr -d ' ')" 2 && is "$(key node_packages | wc -w | tr -d ' ')" 8 &&
is "$(key windows_jobs)" "[]"
check "a pr-require-checks.yml change runs every pr-require-checks.yml lane whole on 12 legs, and test-windows from the selection" $?

Expand Down
Loading