Repository navigation
TaskNotes rc.16: keep the rc.12 starter, add only assignees - #7
Merged
Merged
Conversation
rc.15's type v3 was regenerated from TaskNotes model defaults. Beyond assignees it removed the cancelled status (values, skipped_values, default_skipped and the schema enum), changed status and priority colours, and added the templating and extended profiles. Upgrading a clean rc.12 collection silently dropped cancelled; collections set up by earlier generators conflicted on status definitions and could not be approved. Type v4 is type v1 with only the assignees field, link, mapping, managed field and contract version. The upgrade tests now require that nothing else changes, and cover a collection with generator colours. rc.15 keeps its immutable URL but is no longer listed. Co-Authored-By: Claude <noreply@anthropic.com>
callumalpass
added a commit
to mdbase-dev/mdbase.dev
that referenced
this pull request
Sep 28, 2026
Pins mdbase-contracts 9cda221e (mdbase-dev/mdbase-contracts#7). Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes TaskNotes reapproval failing with "the type pack requires review" and a silent regression in rc.15.
rc.15's task type (v3) was regenerated from TaskNotes model defaults. Beyond
assigneesit:cancelledstatus (values,skipped_values,default_skipped, schema enum),templatingandextendedprofiles.Effects, reproduced on the production engine (mdbase-rs
c456e71b):cancelled;binding/status/definitions, which Connect reported only as "the type pack requires review".rc.16 uses type v4 = rc.12's type v1 + the assignees schema property, link, field mapping, managed field and contract rc.5. All scenarios now apply and keep
cancelledand the collection's own settings.scripts/tasknotes-upgrade.test.mjsrequires the upgraded type to differ only by those changes (this fails for rc.15 in four scenarios) and adds a generator-colours scenario. rc.15 stays at its immutable URL, unlisted.🤖 Generated with Claude Code