serviceability: authorize user instructions via Permission accounts#3984
Open
juan-malbeclabs wants to merge 2 commits into
Open
serviceability: authorize user instructions via Permission accounts#3984juan-malbeclabs wants to merge 2 commits into
juan-malbeclabs wants to merge 2 commits into
Conversation
Migrate UpdateUser to USER_ADMIN, CheckAccessPass to ACTIVATOR, and accesspass CheckStatus to ACTIVATOR|USER_ADMIN via authorize(). UpdateUser uses split_trailing_permission for its optional tenant accounts. Behavior preserved via the legacy foundation/activator fallback. User create and set_bgp_status are intentionally left owner-authorized (access-pass ownership / device.metrics_publisher_pk) and are not part of the admin Permission system.
This was referenced Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gate the administrative user instructions via
authorize():UpdateUser->USER_ADMIN(usessplit_trailing_permissionfor its optional old/new tenant accounts)CheckAccessPass->ACTIVATORCheckStatus->ACTIVATOR | USER_ADMIN(activator or foundation)Behavior preserved via the legacy foundation/activator fallback while
RequirePermissionAccountsis off.CreateUser/CreateSubscribeUserandSetBgpStatusare intentionally not migrated: the account owner authorizes via access-pass ownership (create) ordevice.metrics_publisher_pk(set_bgp_status), so the owner must not need a Permission account — the Permission system is for administrators only.Final PR in the incremental Permission-system rollout; see PERMISSION.md.
Testing Verification
cargo test -p doublezero-serviceability,cargo test -p doublezero_sdk,make rust-lintpass.Permission migration series
One of 8 per-domain PRs migrating serviceability instructions to the Permission (
authorize()) system. The branches partition the change set with no overlap and can be reviewed and merged independently (only the CHANGELOG entry conflicts trivially).