serviceability: authorize multicast instructions via Permission accounts#3982
Open
juan-malbeclabs wants to merge 2 commits into
Open
serviceability: authorize multicast instructions via Permission accounts#3982juan-malbeclabs wants to merge 2 commits into
juan-malbeclabs wants to merge 2 commits into
Conversation
Migrate MulticastGroup create/update/suspend/reactivate/delete to authorize() with MULTICAST_ADMIN, and the publisher/subscriber allowlist add/remove to 'mgroup owner OR MULTICAST_ADMIN' (publisher) / 'mgroup owner OR ACCESS_PASS_ADMIN' (subscriber), preserving the mgroup-owner path. The add handlers use split_trailing_permission to disambiguate the optional user_payer account from the trailing Permission PDA. Behavior preserved via the legacy foundation/sentinel/feed fallback.
This was referenced Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gate MulticastGroup instructions via
authorize(), preserving the group-owner path:create/update/suspend/reactivate/delete) onMULTICAST_ADMINmgroup.owner OR MULTICAST_ADMINmgroup.owner OR ACCESS_PASS_ADMIN(foundation/sentinel/feed legacy)The
addhandlers carry an optionaluser_payeraccount; they usesplit_trailing_permissionso the SDK-appended Permission PDA is distinguished by PDA match rather than a fragile total-account-count heuristic (which fixes a latent ambiguity).Behavior preserved via the legacy fallback while
RequirePermissionAccountsis off. One PR per domain; see PERMISSION.md.Testing Verification
cargo test -p doublezero-serviceability,cargo test -p doublezero_sdk,make rust-lintpass.Permission migration series
One of 8 per-domain PRs migrating serviceability instructions to the Permission (
authorize()) system. The branches partition the change set with no overlap and can be reviewed and merged independently (only the CHANGELOG entry conflicts trivially).