serviceability: authorize link instructions via Permission accounts#3981
Open
juan-malbeclabs wants to merge 2 commits into
Open
serviceability: authorize link instructions via Permission accounts#3981juan-malbeclabs wants to merge 2 commits into
juan-malbeclabs wants to merge 2 commits into
Conversation
Migrate Link create/update/delete/suspend/resume/accept/sethealth to authorize(). Owner-or-privileged handlers accept the contributor owner OR NETWORK_ADMIN (foundation legacy); accept gains a NETWORK_ADMIN bypass; sethealth accepts HEALTH_ORACLE|NETWORK_ADMIN. delete/update use split_trailing_permission to peel payer/system/permission off the tail past the variable topology union. Internal foundation sub-gates extended to NETWORK_ADMIN (is_privileged). Behavior preserved via the legacy fallback.
This was referenced Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gate Link instructions on
NETWORK_ADMIN(andHEALTH_ORACLEforsethealth) viaauthorize(), preserving the contributor-owner path:create,update,delete,suspend,resume,accept,sethealthOwner-or-admin handlers become
owner OR authorize(NETWORK_ADMIN);accept(previously owner-only) gains a NETWORK_ADMIN bypass;sethealthcomposesHEALTH_ORACLE | NETWORK_ADMIN.deleteandupdateare variable-length (topology union parsed off the tail) and usesplit_trailing_permissionso the trailing Permission PDA is disambiguated by PDA match. Internal foundation-only sub-gates (per-link contributor binding, tunnel-field / topology / unicast_drained edits) are extended toNETWORK_ADMINholders.Behavior preserved via the legacy fallback while
RequirePermissionAccountsis off. One PR per domain; see PERMISSION.md.Testing Verification
cargo test -p doublezero-serviceability,cargo test -p doublezero_sdk,make rust-lintpass.Permission migration series
One of 8 per-domain PRs migrating serviceability instructions to the Permission (
authorize()) system. The branches partition the change set with no overlap and can be reviewed and merged independently (only the CHANGELOG entry conflicts trivially).