Skip to content

Use the slide-down top sheet for the album badge and seek slider on every screen - #441

Merged
lstein merged 3 commits into
masterfrom
lstein/feature/top-sheet-everywhere
Nov 17, 2026
Merged

lstein merged 3 commits into
masterfrom
lstein/feature/top-sheet-everywhere

Conversation

@lstein

@lstein lstein commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Summary

The phone layout's top sheet (album badge + seek slider, sliding down from the top edge) now applies on tablets and desktop browsers too. The bottom sheet (Control/Search panels + metadata details) is unchanged and still phone-only.

  • Separate switch for the top sheet. <meta name="top-sheet-query"> (currently all) sets html.top-sheet, independent of html.mobile-sheets. Each sheet in mobile-sheets.js follows its own mode (Sheet.active()), and the top-sheet CSS keys off .top-sheet. To limit it to some screens later, change that media query. It must match wherever the phone query does.
  • Shorter sheet (≈160px → 119px open). The badge is one row in the sheet: slide count first, then the reindex button and album pulldown. The padding around the slider is trimmed.
  • Cluster colour on the count only. In the sheet, a selected cluster colours the slide count / cluster name as its own pill (score-display.js applyColors). The rest of the badge stays dark. Outside top-sheet mode it colours the whole badge, as before.
  • Fullscreen. The whole top sheet (handle and progress strip included) is hidden in fullscreen on every screen, and the grid gets the top row back. Fullscreen rules use the :is(:fullscreen, :-webkit-full-screen) form from Make the fullscreen CSS rules apply in every browser #443.
  • Keyboard. events.js takes all buttons out of the tab order, which, with the collapsed sheet inert, left the album pulldown unreachable by keyboard. The sheet handles now stay tabbable (a mouse press doesn't leave focus on them).

Behaviour notes for testing

  • On desktop the open sheet stays open until the handle is clicked again (no auto-fade or outside-click close), the same as on phones. Open, it covers the first grid row.

Test plan

  • npm test (1151 pass), npm run lint, npm run format:check
  • New Jest tests: top sheet active without the phone layout, top-query off, fullscreen hiding, cluster pill colouring and recolouring
  • Headless Chromium at 1440×900, iPad and phone sizes: collapse/expand, one-row badge, cluster pill (dark and light colours), Tab → handle → Enter opens, fullscreen hides the whole sheet (Chromium and Firefox)
  • Device testing on tablets and phones (author)

🤖 Generated with Claude Code

lstein and others added 2 commits November 15, 2026 22:32
The badge and seek slider fold into the slide-down top sheet on tablets and
desktop browsers too, not only on phones. The top sheet gets its own switch
(<meta name="top-sheet-query">, currently "all", published as html.top-sheet)
separate from the phone layout's, which still governs the bottom sheet.

In the sheet the badge is one line (slide count first, then the reindex
button and album pulldown), the slider padding is trimmed, and a selected
cluster colours only the slide count and cluster name rather than the whole
badge.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review fixes: outside the phone layout the top sheet now stays in fullscreen
(the slider was otherwise unreachable there, where the hover strip used to
allow seeking), with the grid reserving its strip; the sheet handles stay in
the tab order so a collapsed sheet's album pulldown can still be reached; and
the badge recolours if the top-sheet mode changes under a shown cluster.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@lstein
lstein force-pushed the lstein/feature/top-sheet-everywhere branch from 1870db2 to d1f3e44 Compare November 16, 2026 03:33
Handle and progress strip included; the grid gets the top row back.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@lstein
lstein merged commit 2088cc8 into master Nov 17, 2026
11 checks passed
@lstein
lstein deleted the lstein/feature/top-sheet-everywhere branch November 17, 2026 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant