Repository navigation
Make the fullscreen CSS rules apply in every browser - #443
Merged
Merged
Conversation
Each fullscreen rule listed :fullscreen beside prefixed forms in a plain selector list. One pseudo-class a browser does not know invalidates the whole rule, and every browser rejects one of them (Firefox :-webkit-full-screen, Chromium :-moz-full-screen), so the album badge was never hidden in fullscreen, and in Firefox neither were the phone sheets nor the grid's fullscreen height. Wrap the alternatives in :is(), whose forgiving selector list drops only the unknown one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lstein
enabled auto-merge (squash)
November 16, 2026 03:28
lstein
disabled auto-merge
November 16, 2026 03:31
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #442.
Summary
Every fullscreen rule listed
:fullscreenbeside prefixed forms in a plain selector list. One unknown pseudo-class invalidates the whole rule, and each browser rejects one of them, so these rules were dead:seek-slider.css: hide the album badge (:-moz-full-screen,:-ms-fullscreenlisted)grid-view.css: grid top reserve → 0:-webkit-full-screen)grid-view.css: phone grid full heightmobile-sheets.css: hide the phone sheetsThe alternatives now go inside
:is(), whose selector list is forgiving: a browser drops only the alternative it doesn't know.:is()keeps the specificity of a single pseudo-class, as before.:-webkit-full-screenstays for Safari before 16.4.-moz/-msare gone (Firefox has supported unprefixed:fullscreensince 64;-ms-was IE/old Edge, which we redirect to the unsupported-browser page).Visible change: in fullscreen the album badge is now hidden in Chrome and Firefox, as the rule always intended. The JS already assumed it could be hidden: the metadata drawer falls back to a fixed top, and the slider/strip re-anchor at the left edge on the fullscreen resize.
Test plan
cssRules; after, all are present in both.displayflex → none in fullscreen → flex after exit;--grid-top-reserve0px in fullscreen.npm test(1141 pass)Note for #441: that branch adds more
:fullscreen, :-webkit-full-screenpairs; it will be converted to the:is()form when rebased onto this.🤖 Generated with Claude Code