Skip to content

Album badge is not hidden in fullscreen: invalid vendor selectors drop the whole CSS rule #442

Closed

Description

@lstein

Problem

photomap/frontend/static/css/seek-slider.css (lines 121–127 on master) is meant to hide the album badge in fullscreen:

/* Hide score display in fullscreen mode */
:fullscreen .fixed-score-display,
:-webkit-full-screen .fixed-score-display,
:-moz-full-screen .fixed-score-display,
:-ms-fullscreen .fixed-score-display {
  display: none !important;
}

A selector list containing any selector the browser doesn't recognise invalidates the whole rule. Every browser rejects at least one of these vendor pseudo-classes (Chromium rejects :-moz-full-screen; Firefox rejects :-ms-fullscreen), so the rule is never applied and the badge stays visible in fullscreen.

Verified

With headless Chromium and Firefox (Playwright 1.63), the rule is missing from the parsed seek-slider.css cssRules in both. After document.documentElement.requestFullscreen(), #fixedScoreDisplay's computed display is still flex in both.

Fix

Split the selectors into separate rules, one per prefix (or drop -moz/-ms and keep :fullscreen and :-webkit-full-screen as two rules), so an unknown one can't take the others down with it. Check whether anything else has come to rely on the badge being visible in fullscreen first.

Related comments now assume the rule works: grid-view.css ("The badge is hidden in fullscreen (seek-slider.css), so give the row back") and, on PR #441, mobile-sheets.css's note that the desktop fullscreen top sheet shows without the badge.

Found while reviewing #441.

🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions