Repository navigation
feat(investigations): Post comments from the Activity section - #127574
Conversation
Story previewsPreview the stories changed in this PR on the Vercel deployment: Preview deployment: https://sentry-hdgbc242w.sentry.dev |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7b3c0df. Configure here.
Add a composer under the Activity feed. Enter sends the comment. The header button shows the comment count and moves focus to the composer. Archived investigations do not show the composer.
0a40137 to
f793c2c
Compare
billyvg
left a comment
There was a problem hiding this comment.
🤖 AI review by Claude, an AI agent. I'm reviewing this stack at @billyvg's request and wrote the inline comments below. @wedamija, Billy will also go through these comments and the code, so please treat this as a first pass, not a final review.
One small correctness issue (the header count tops out at 100) and two minor UX notes.
The count sits before the viewers instead of in the top bar. On archived investigations it scrolls to Activity, and it is hidden when there are no comments.
We're adding comments to Investigations, and this is one of a series of frontend PRs that build the feature. Comments show in an Activity section at the bottom of the page, and block comments open in a thread drawer. Everything is behind the `investigations` flag. This PR adds edit and delete for the comment's author: - A "…" menu on your own comments with Edit and Delete. - Edit opens the comment inline. Enter saves, Esc cancels. - Delete asks for confirmation first. - Edited comments show "(edited)". Stacked on #127574. The next PR adds block comments in a drawer.
Visual QAScreenshots from Scraps stories (fixture data, 1440×900, light theme). "Before" is the #127498 head with the same story and data. Story coverage: the header comment button goes into
Header button with the count (no before frame, since stories had no top bar):
The header button scrolls the composer into view and focuses it:
Checked in the browser:
|
### Why? The comments PRs shipped without story coverage. The stories' fixture API throws on any investigation endpoint it doesn't know, so since the Activity section landed, every investigation page story shows a loading error in Activity. Posting, editing, block threads, and the comment entry points can't be reached from Scraps at all. A thread opened from a story also rendered outside the fixture and requested the real API. ### How? Teach the fixture API the comment endpoints and mount a drawer inside it, then add stories for each comment state. There is one commit per comments PR. Stories view the page as a fixed persona, so they look the same for everyone. Screenshots from these stories are in the visual QA comments on each PR: - #127498 - #127574 - #127576 - #127590 - #127593 <sub>Generated with Claude Code</sub> --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
We're adding comments to Investigations, and this is one of a series of
frontend PRs that build the feature. Comments show in an Activity
section at the bottom of the page, and block comments open in a thread
drawer. Everything is behind the `investigations` flag.
This PR adds posting comments:
- A composer under the Activity feed. Enter sends the comment.
- The metadata line shows the comment count ("Comment" when there are
none) before the viewers. Clicking it moves focus to the composer; on
archived investigations it scrolls to Activity.
- Archived investigations do not show the composer.
Stacked on #127498. The next PR
adds edit and delete.
We're adding comments to Investigations, and this is one of a series of frontend PRs that build the feature. Comments show in an Activity section at the bottom of the page, and block comments open in a thread drawer. Everything is behind the `investigations` flag. This PR adds edit and delete for the comment's author: - A "…" menu on your own comments with Edit and Delete. - Edit opens the comment inline. Enter saves, Esc cancels. - Delete asks for confirmation first. - Edited comments show "(edited)". Stacked on #127574. The next PR adds block comments in a drawer.
### Why? The comments PRs shipped without story coverage. The stories' fixture API throws on any investigation endpoint it doesn't know, so since the Activity section landed, every investigation page story shows a loading error in Activity. Posting, editing, block threads, and the comment entry points can't be reached from Scraps at all. A thread opened from a story also rendered outside the fixture and requested the real API. ### How? Teach the fixture API the comment endpoints and mount a drawer inside it, then add stories for each comment state. There is one commit per comments PR. Stories view the page as a fixed persona, so they look the same for everyone. Screenshots from these stories are in the visual QA comments on each PR: - #127498 - #127574 - #127576 - #127590 - #127593 <sub>Generated with Claude Code</sub> --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>









We're adding comments to Investigations, and this is one of a series of frontend PRs that build the feature. Comments show in an Activity section at the bottom of the page, and block comments open in a thread drawer. Everything is behind the
investigationsflag.This PR adds posting comments:
Stacked on #127498. The next PR adds edit and delete.