Repository navigation
Conversation
github-actions
Bot
added
the
Scope: Frontend
Contributor
Story previewsPreview the stories changed in this PR on the Vercel deployment:
Preview deployment: https://sentry-7mn69jz07.sentry.dev |
Contributor
📊 Type Coverage Diff
🔍 1 new type safety issue introduced
This is informational only and does not block the PR. |
Base automatically changed from
danf/investigations-block-comments-entry
to
master
October 16, 2026 17:09
The detail stories' fixture API threw on the new comments endpoint, so every investigation page story rendered an error in its Activity section. Serve comments from the fixture (none by default), and add stories for the Activity states and for comments on a full investigation page. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Let the fixture API accept new comments, posted as a fixed story persona so the stories look the same for everyone. Add a top bar to page stories that need one, since the comment button lives in the app's top bar, which stories don't render, and cover the archived state. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Let the fixture API edit and delete comments, and give the story persona's comments the signed-in user's id so the author-only actions show. Add a story for your own comments, including an edited one. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Drawers render where GlobalDrawer is mounted, so a thread opened from a story read the real organization and API and failed to load. Mount a GlobalDrawer inside the fixture, filter comments by block, and give the query block a thread to open. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Serve per-block comment counts from the fixture API so page stories show the pinned comment button, and add a cell story for the button with and without comments. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
billyvg
force-pushed
the
billyvg/test/investigations-comments-stories
branch
from
October 16, 2026 18:34
312af70 to
09a3abb
Compare
billyvg
marked this pull request as ready for review
October 16, 2026 18:41
ryan953
approved these changes
Oct 16, 2026
…ndex The Scraps "On this page" index lists every heading in a story, so each Activity section, chart title, and the thread drawer added an entry. Mark the fixture's contents as demo content, which the index skips. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Only the fixture API uses it, so knip flagged the export. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The comments PRs shipped without story coverage. The stories' fixture API throws on any investigation endpoint it doesn't know, so since the Activity section landed, every investigation page story shows a loading error in Activity. Posting, editing, block threads, and the comment entry points can't be reached from Scraps at all. A thread opened from a story also rendered outside the fixture and requested the real API.
How?
Teach the fixture API the comment endpoints and mount a drawer inside it, then add stories for each comment state. There is one commit per comments PR. Stories view the page as a fixed persona, so they look the same for everyone.
Screenshots from these stories are in the visual QA comments on each PR:
Generated with Claude Code