Repository navigation
feat(investigations): Edit and delete comments - #127576
Conversation
📊 Type Coverage Diff
🔍 1 new type safety issue introducedType assertions (
This is informational only and does not block the PR. |
7b64a7b to
30f6171
Compare
0a40137 to
f793c2c
Compare
billyvg
left a comment
There was a problem hiding this comment.
🤖 AI review by Claude, an AI agent. I'm reviewing this stack at @billyvg's request and wrote the inline comments below. @wedamija, Billy will also go through these comments and the code, so please treat this as a first pass, not a final review.
Ryan's isPending and toast comments are addressed in 524b53b, and Bugbot's catch about archived actions is fixed in 30f6171, so I didn't repeat those. I have one question about the "(edited)" threshold and one small focus nit.
Sentry Snapshot Testing
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9a83a71. Configure here.
Comment authors get a menu on their own comments with Edit and Delete. Edit opens the comment inline: Enter saves, Esc cancels. Delete asks for confirmation first, then moves focus to the composer. Edited comments show "(edited)", and actions are hidden on archived investigations.
60c6095 to
4dd7894
Compare
Visual QAScreenshots from Scraps stories (fixture data, 1440×900, light theme). "Before" is the #127574 head with the same story and data. Story coverage: no story had comments by the signed-in user, so the actions menu never showed. The fixture now handles
Checked in the browser:
|
### Why? The comments PRs shipped without story coverage. The stories' fixture API throws on any investigation endpoint it doesn't know, so since the Activity section landed, every investigation page story shows a loading error in Activity. Posting, editing, block threads, and the comment entry points can't be reached from Scraps at all. A thread opened from a story also rendered outside the fixture and requested the real API. ### How? Teach the fixture API the comment endpoints and mount a drawer inside it, then add stories for each comment state. There is one commit per comments PR. Stories view the page as a fixed persona, so they look the same for everyone. Screenshots from these stories are in the visual QA comments on each PR: - #127498 - #127574 - #127576 - #127590 - #127593 <sub>Generated with Claude Code</sub> --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
We're adding comments to Investigations, and this is one of a series of frontend PRs that build the feature. Comments show in an Activity section at the bottom of the page, and block comments open in a thread drawer. Everything is behind the `investigations` flag. This PR adds edit and delete for the comment's author: - A "…" menu on your own comments with Edit and Delete. - Edit opens the comment inline. Enter saves, Esc cancels. - Delete asks for confirmation first. - Edited comments show "(edited)". Stacked on #127574. The next PR adds block comments in a drawer.
### Why? The comments PRs shipped without story coverage. The stories' fixture API throws on any investigation endpoint it doesn't know, so since the Activity section landed, every investigation page story shows a loading error in Activity. Posting, editing, block threads, and the comment entry points can't be reached from Scraps at all. A thread opened from a story also rendered outside the fixture and requested the real API. ### How? Teach the fixture API the comment endpoints and mount a drawer inside it, then add stories for each comment state. There is one commit per comments PR. Stories view the page as a fixed persona, so they look the same for everyone. Screenshots from these stories are in the visual QA comments on each PR: - #127498 - #127574 - #127576 - #127590 - #127593 <sub>Generated with Claude Code</sub> --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>







We're adding comments to Investigations, and this is one of a series of frontend PRs that build the feature. Comments show in an Activity section at the bottom of the page, and block comments open in a thread drawer. Everything is behind the
investigationsflag.This PR adds edit and delete for the comment's author:
Stacked on #127574. The next PR adds block comments in a drawer.