Repository navigation
Conversation
The modal, the condition specs, and the save mutation move out of the settings table file into customFilterModal.tsx. The modal now owns POST and PUT and invalidates the list query, so a caller only picks what it opens on through openCustomFilterModal. This prepares entry points outside of project settings.
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff
🔍 2 new type safety issues introducedType assertions (
This is informational only and does not block the PR. |
The merge from master added InfoText uses to the table file, but the import block moved to the modal module in this branch. Also stop exporting FilterFormValues, which no other module reads. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
shellmayr
marked this pull request as ready for review
October 14, 2026 07:29
…m-filter-modal-module # Conflicts: # static/app/views/settings/project/projectFilters/customFilters.tsx # static/app/views/settings/project/projectFilters/index.spec.tsx
…l-module' into shellmayr/ref/custom-filter-modal-module
Dav1dde
approved these changes
Oct 15, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
customFilters.tsxintocustomFilterModal.tsx.openCustomFilterModal({project, filter?}); the table keeps only the toggle and delete mutations.GlobalModalin the same tree as the page, since a separate render has its own query client and never saw the invalidation.Closes TET-3108