Skip to content

feat(inbound-filters): Add an issue action that drafts a custom filter from the event - #126853

Draft
shellmayr wants to merge 3 commits into
masterfrom
shellmayr/feat/add-inbound-filter-issue-action
Draft

shellmayr wants to merge 3 commits into
masterfrom
shellmayr/feat/add-inbound-filter-issue-action

Conversation

@shellmayr

@shellmayr shellmayr commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Closes TET-3107

The modal, the condition specs, and the save mutation move out of the settings table file into customFilterModal.tsx. The modal now owns POST and PUT and invalidates the list query, so a caller only picks what it opens on through openCustomFilterModal. This prepares entry points outside of project settings.
…r from the event

The issue details More Actions menu gets an Add Inbound Filter item. It opens the custom filter modal with one condition per property the shown event carries (exception type and message, country, release, IP), so the user removes rows instead of typing patterns. Event text is escaped as a Relay glob and raw exception values win over symbolicated ones.

The item is gated on inbound-filters-v2, inbound-filters-v2-ui, and the new inbound-filters-in-product-flows flag.
@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

📊 Type Coverage Diff

Metric Before After Delta
Coverage 95.69% 95.69% ±0%
Typed 142,391 142,416 🟢 +25
Untyped 6,415 6,416 🔴 +1
🔍 1 new type safety issue introduced

Type assertions (as) (1 new)

File Line Detail
static/app/views/settings/project/projectFilters/customFilterModal.tsx 437 as string[] — [...new Set(values.map(value => value?.trim()).filter(Boolean))] as string[]

This is informational only and does not block the PR.

…an feature

The API refuses custom filter writes without projects:custom-inbound-filters, so the Add Inbound Filter item says so up front instead of letting the modal fail on save.
@linear-code

linear-code Bot commented Oct 13, 2026

Copy link
Copy Markdown

TET-3107

shellmayr added a commit that referenced this pull request Oct 14, 2026
…flag (#126851)

- Registers `organizations:inbound-filters-in-product-flows` in
`temporary.py` with `api_expose=True`.
- Gates custom inbound filter entry points outside of project settings,
starting with the issue actions menu (#126853).
Base automatically changed from shellmayr/ref/custom-filter-modal-module to master October 15, 2026 12:49

This branch was successfully deployed

1 active deployment
Preview — c36804d2 Deployed Oct 8, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant