Repository navigation
fix: show live time marker when radio programme guide has a gap - #291
Merged
Merged
Conversation
…broadcaster guide has a gap
… preserve manual scrolling
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
ePlus-DEV is on CodeRabbit Free, which includes PR summaries. Ask your admin to upgrade for code reviews.
Comment |
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
At 16:29 Vietnam time, VOV Giao thông TP.HCM's guide has no listed show: FM91 ends at 16:15 and Giờ cao điểm chiều starts at 16:30. The current Queue schedule scrolls toward 16:30 with no indication of where the current time is, which looks like a schedule/highlight bug. The gap does not prove the station is silent.
Change
Regression coverage
Unit tests explicitly check 16:29 ICT → 16:30 ICT, gaps before/after listed shows, and no false live indicator. Opt-in Playwright tests check marker visibility, scroll location, midnight-independent ICT time, transition and manual scroll.
Target develop, follow with production release only after full CI checks.