Skip to content

fix: show live time marker when radio programme guide has a gap - #291

Merged
hoangsvit merged 13 commits into
developfrom
fix/schedule-gap-now-marker-20261014
Oct 14, 2026
Merged

hoangsvit merged 13 commits into
developfrom
fix/schedule-gap-now-marker-20261014

Conversation

@hoangsvit

Copy link
Copy Markdown
Member

Problem

At 16:29 Vietnam time, VOV Giao thông TP.HCM's guide has no listed show: FM91 ends at 16:15 and Giờ cao điểm chiều starts at 16:30. The current Queue schedule scrolls toward 16:30 with no indication of where the current time is, which looks like a schedule/highlight bug. The gap does not prove the station is silent.

Change

  • Inject a compact Now (16:29) timeline marker into the schedule list at the correct chronological location with a horizontal rose accent line, No programme information for this time, and Up next (scheduled): Giờ cao điểm chiều · 16:30.
  • Mark gaps before, between, and after listed time windows without fabricating an on-air programme. Show a useful no-next-message when no further reference programme exists today.
  • Center the schedule's inner scroll container on the new marker when a time gap exists, instead of jumping directly to the next show. Existing Jump to current time and manual-scroll protection still work.
  • Update dynamically every 15 seconds; at 16:30 the gap marker disappears and the genuine scheduled programme becomes active, without claiming any exact EPG playback verification.
  • Limit this to sourced reference schedules. Remote provider real-time programmes and non-Vietnam station queues are unchanged.
  • Localize in all 7 supported languages and add docs.

Regression coverage

Unit tests explicitly check 16:29 ICT → 16:30 ICT, gaps before/after listed shows, and no false live indicator. Opt-in Playwright tests check marker visibility, scroll location, midnight-independent ICT time, transition and manual scroll.

Target develop, follow with production release only after full CI checks.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@coderabbitai

coderabbitai Bot commented Oct 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: ePlus-DEV/radio.eplus.dev/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Free
  • Run ID: 81054c5d-b277-44c0-917f-b2195195bbbd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

ePlus-DEV is on CodeRabbit Free, which includes PR summaries. Ask your admin to upgrade for code reviews.

  • Ask an admin to upgrade

Open in CodeRabbit

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@hoangsvit
hoangsvit merged commit d8a8b97 into develop Oct 14, 2026
3 checks passed
@hoangsvit
hoangsvit deleted the fix/schedule-gap-now-marker-20261014 branch October 15, 2026 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant