Repository navigation
Abandon a Surface move whose late iframe consent would replace a newer question - #1482
Merged
Merged
Conversation
…r question moveSurface asks for iframe consent a second time after awaiting both Walls' persistence flush, for a Tool that starts serving meanwhile. It dropped the guard cancelPendingConfirmation returns, so a Workspace close asked during that flush was answered no when the move raised its own question. The move now gives up instead, as layout.md requires of superseded preparation.
Deploying mouseterm with
|
| Latest commit: |
6da5f6b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://63bc0050.mouseterm.pages.dev |
| Branch Preview URL: | https://fix-surface-move-stale-conse.mouseterm.pages.dev |
dormouse-bot
commented
Oct 31, 2026
dormouse-bot
left a comment
dormouse-bot
left a comment
Collaborator
Author
There was a problem hiding this comment.
CI is red only on Argos: argos/storybook-chromium and argos/storybook-webkit each report "1 changed — waiting for your decision". This PR changes no component or story, only the consent guard in moveSurface, one WorkspaceWindow.test.tsx case and a spec phrase, and #1479 and #1480 show the same "1 changed" status, so this looks like baseline drift rather than something this diff rendered. The visual diff still needs a maintainer's accept or reject in Argos before the checks go green.
This was referenced Oct 31, 2026
`PairedPhonesAndAccessLog` built its log in a `parameters` literal, which runs at module load, before the meta's `beforeEach` pins `Date.now` to `STORY_NOW`. The log therefore carried the CI runner's wall-clock time, and every PR showed an Argos diff on `modals-remotecontrolsection--paired-phones-and-access-log`. `pairedDevices` and `accessLogEntries` now take an optional `now`, and the story passes `STORY_NOW`; `OneTimeEndedNetworkNotAllowed`'s refusal time gets the same treatment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A GUI Surface move could answer a newer Workspace close "no" and put its own "Move iframe?" question in its place.
moveSurfaceasks for iframe consent a second time after awaiting both Walls'flushPersistence, to cover a Tool that starts serving an iframe in that window. It threw away the guard thatcancelPendingConfirmation()returns, though. A busy Workspace close requested during the flush therefore raised its question first, and the move's laterequestConfirmationanswered it no. The move now checks that guard before asking and abandons itself, returningnulland releasing its transfer guards, the same waycloseOnceWallRegistersdoes.docs/specs/layout.md→ "Workspace lifecycle" already requires superseded preparation to be abandoned. This PR adds the persistence flush to the list of awaits that rule names.The first consent is unaffected. It runs before any await, so the guard is still current there, and the second consent only asks when the first one didn't.
The new
WorkspaceWindow.test.tsxcase fails onmain: the pending confirmation is the move'sMove iframe?instead of the Workspace 3 close. It passes here, along with the rest of that file andsurface-workspace-drag.test.ts(75 tests).