Skip to content

Correct stale comments left by alert deferral's removal and dor remote routing - #1480

Open
dormouse-bot wants to merge 2 commits into
mainfrom
docs/stale-comments-2026-10-31
Open

dormouse-bot wants to merge 2 commits into
mainfrom
docs/stale-comments-2026-10-31

Conversation

@dormouse-bot

Copy link
Copy Markdown
Collaborator

Comment and doc corrections only; no behavior changes. Each line below stopped matching the code after this week's merges.

  • lib/src/lib/alert-manager.ts (commandFinished): drops "confirmed work never delays it. The detector only gates in-band terminal notifications". Since Drop alert deferral; a progress cycle, not a settle, ends a turn #1368 removed alert deferral, the detector gates no notification.
  • lib/src/lib/terminal-registry.alert.test.ts: "It may defer presentation" now reads as a guarantee that no longer exists.
  • lib/src/lib/terminal-protocol.ts: the comment credited collectTerminalSemanticEvents with the authoritative updatedAt. The live host path is applyTerminalEvents, and both go through semanticEventOf.
  • docs/specs/dor-cli.md → "Handle Model" figure: resolveRoute answers remote.* alongside app.* and tool.* (Revoke a paired phone live, and keep an owner-local access log #1459), and the "dor remote" section defers to that figure.
  • docs/specs/mouse-and-clipboard.md Spaces row: the first line keeps its quote prefix, which copy-text.test.ts pins. Only lines after a deleted break lose theirs, as the Decoration paragraph's rule already says.
  • website/src/index.css: the "180 of the library's 430 files" count is now 376 of 875. The comment no longer gives a number.
  • docs/testing/dor-tool-dirty.md: save coordination and close protection have shipped (docs/specs/dor-tool.md → "Closing unsaved Tools").

Ran spec-lint, md-unwrap, and the alert-manager and terminal-registry alert suites (246 tests), all passing.

…e routing

- alert-manager: drop the claim that the detector gates notifications;
  since #1368 nothing defers a ring.
- terminal-registry.alert test: nothing defers presentation any more.
- terminal-protocol: the live path timestamps through semanticEventOf,
  not only collectTerminalSemanticEvents.
- dor-cli.md: the routing figure answers remote.* with app.* and tool.*.
- mouse-and-clipboard.md: Spaces keeps the first line's quote prefix.
- website index.css and the dor-tool-dirty QC log: stale counts and scope.
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Deploying mouseterm with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3f741a9
Status: ✅  Deploy successful!
Preview URL: https://eef030c7.mouseterm.pages.dev
Branch Preview URL: https://docs-stale-comments-2026-10-stnd.mouseterm.pages.dev

View logs

@dormouse-bot dormouse-bot left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The routing figure still omits window.*: resolveRoute in lib/src/components/wall/dor-control-router.ts returns { kind: 'reopen' } for window.reopen before any Workspace resolves, and the "dor reopen" section defers to this figure in the same way "dor remote" does. As written, a reader following the figure would send dor reopen down the --workspace / caller branches.

Comment thread docs/specs/dor-cli.md Resolved
@dormouse-bot

Copy link
Copy Markdown
Collaborator Author

The window.* routing finding is fixed in 3f741a9. CI is now red only on Argos. argos/storybook-chromium and argos/storybook-webkit each report "1 changed — waiting for your decision". Nothing in this diff renders differently: the code edits only change comments, and the website/src/index.css edit rewrites a CSS comment. #1479, #1482, #1483, and #1485 show the same single pending change, so it looks like a shared baseline change rather than something this PR caused. A maintainer needs to accept or reject it in Argos (chromium build 2038, webkit build 2037). Every other check passed at this head, apart from the Hosted PR preview deploy job, which waits for approval.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant