Repository navigation
Correct stale comments left by alert deferral's removal and dor remote routing - #1480
dormouse-bot wants to merge 2 commits into
Conversation
…e routing - alert-manager: drop the claim that the detector gates notifications; since #1368 nothing defers a ring. - terminal-registry.alert test: nothing defers presentation any more. - terminal-protocol: the live path timestamps through semanticEventOf, not only collectTerminalSemanticEvents. - dor-cli.md: the routing figure answers remote.* with app.* and tool.*. - mouse-and-clipboard.md: Spaces keeps the first line's quote prefix. - website index.css and the dor-tool-dirty QC log: stale counts and scope.
Deploying mouseterm with
|
| Latest commit: |
3f741a9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://eef030c7.mouseterm.pages.dev |
| Branch Preview URL: | https://docs-stale-comments-2026-10-stnd.mouseterm.pages.dev |
dormouse-bot
left a comment
There was a problem hiding this comment.
The routing figure still omits window.*: resolveRoute in lib/src/components/wall/dor-control-router.ts returns { kind: 'reopen' } for window.reopen before any Workspace resolves, and the "dor reopen" section defers to this figure in the same way "dor remote" does. As written, a reader following the figure would send dor reopen down the --workspace / caller branches.
|
The |
Comment and doc corrections only; no behavior changes. Each line below stopped matching the code after this week's merges.
lib/src/lib/alert-manager.ts(commandFinished): drops "confirmed work never delays it. The detector only gates in-band terminal notifications". Since Drop alert deferral; a progress cycle, not a settle, ends a turn #1368 removed alert deferral, the detector gates no notification.lib/src/lib/terminal-registry.alert.test.ts: "It may defer presentation" now reads as a guarantee that no longer exists.lib/src/lib/terminal-protocol.ts: the comment creditedcollectTerminalSemanticEventswith the authoritativeupdatedAt. The live host path isapplyTerminalEvents, and both go throughsemanticEventOf.docs/specs/dor-cli.md→ "Handle Model" figure:resolveRouteanswersremote.*alongsideapp.*andtool.*(Revoke a paired phone live, and keep an owner-local access log #1459), and the "dor remote" section defers to that figure.docs/specs/mouse-and-clipboard.mdSpaces row: the first line keeps its quote prefix, whichcopy-text.test.tspins. Only lines after a deleted break lose theirs, as the Decoration paragraph's rule already says.website/src/index.css: the "180 of the library's 430 files" count is now 376 of 875. The comment no longer gives a number.docs/testing/dor-tool-dirty.md: save coordination and close protection have shipped (docs/specs/dor-tool.md→ "Closing unsaved Tools").Ran
spec-lint,md-unwrap, and the alert-manager and terminal-registry alert suites (246 tests), all passing.