Repository navigation
Pin the access-log story's timestamps to the story clock - #1487
Merged
Merged
Conversation
`PairedPhonesAndAccessLog` built its log in a `parameters` literal, which runs at module load, before the meta's `beforeEach` pins `Date.now` to `STORY_NOW`. The log therefore carried the CI runner's wall-clock time, and every PR showed an Argos diff on `modals-remotecontrolsection--paired-phones-and-access-log`. `pairedDevices` and `accessLogEntries` now take an optional `now`, and the story passes `STORY_NOW`; `OneTimeEndedNetworkNotAllowed`'s refusal time gets the same treatment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deploying mouseterm with
|
| Latest commit: |
7a1c721
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://899c0bb6.mouseterm.pages.dev |
| Branch Preview URL: | https://fix-access-log-story-clock.mouseterm.pages.dev |
dormouse-bot
approved these changes
Oct 31, 2026
nedtwigg
added a commit
that referenced
this pull request
Nov 1, 2026
Brings in #1487's story-clock fix for the access-log story, which is the one changed Argos snapshot every open PR showed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nedtwigg
added a commit
that referenced
this pull request
Nov 1, 2026
Brings in #1487's story-clock fix for the access-log story, which is the one changed Argos snapshot every open PR showed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nedtwigg
added a commit
that referenced
this pull request
Nov 1, 2026
Brings in #1487's story-clock fix for the access-log story, which is the one changed Argos snapshot every open PR showed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PairedPhonesAndAccessLogbuilt its access log in aparametersliteral, which runs at module load — before the meta'sbeforeEachpinsDate.nowtoSTORY_NOW. The log carried the CI runner's wall-clock time, so every PR showed an Argos diff onmodals-remotecontrolsection--paired-phones-and-access-log(#1482, #1483, #1485: same baseline, three different compare images, only the log rows differ).pairedDevicesandaccessLogEntriesinlib/src/host/remote/test-burrow-link.tstake an optionalnow(defaultDate.now(), so tests are unchanged).STORY_NOW;OneTimeEndedNetworkNotAllowed's refusalatdoes too (not rendered there today, but the same trap).STORY_NOWcomment says why aparametersliteral must use it directly.Two local Argos renders a minute apart are byte-identical. Expect one final baseline change on this PR (log now reads Dec 30–31, 2025, matching the paired-phones list above it); approve it and the snapshot is stable thereafter.
🤖 Generated with Claude Code