Repository navigation
Refuse a .. step behind a backslash in a browser binary path - #1479
Open
dormouse-bot wants to merge 1 commit into
Open
dormouse-bot wants to merge 1 commit into
dormouse-bot wants to merge 1 commit into
Conversation
#1449 split a POSIX-form candidate on `/` alone, so the `..` check stopped seeing `\..\` in it. A Windows host reads `/opt\..\x/agent-browser.exe` as rooted on the current drive with `\` as a separator, so the gate accepted a parent step S168 says it refuses. The `..` check now splits on both separators; the file-name check keeps the per-form split. Re-seeds the unc-binary-path canary over the moved lines.
Deploying mouseterm with
|
| Latest commit: |
a9f7d7b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://faa94543.mouseterm.pages.dev |
| Branch Preview URL: | https://fix-browser-binary-dotdot-ba.mouseterm.pages.dev |
dormouse-bot
commented
Oct 31, 2026
dormouse-bot
left a comment
dormouse-bot
left a comment
Collaborator
Author
There was a problem hiding this comment.
CI is red only on Argos: argos/storybook-chromium and argos/storybook-webkit each report "1 changed — waiting for your decision". This PR changes no component or story, only the binary-path gate in dor-lib-common/src/browser-providers.ts, its unit test, and an audit canary. The same Argos status is on #1474, #1475, and #1476, so the changed snapshot most likely comes from outside this diff. A maintainer needs to accept or reject it in Argos. Every other check passed at a9f7d7b.
This was referenced Oct 31, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The browser-binary gate accepted
/opt\..\x/agent-browser.exeafter #1449. On a Windows host that path is rooted on the current drive,\is a separator, and the..is a real parent step, whichdocs/specs/security-local.mdS168 says the gate refuses. This PR makes the..check split on both separators again, while the file-name check keeps #1449's per-form split, so/r/x\agent-browserstays refused on POSIX.#1449 split a POSIX-form candidate (leading
/) on/alone, which correctly treats\as a file-name character for the file-name check. It also fed the..check, though, and the same gate runs on Windows hosts (VS Code, standalone), where a leading-/path is not POSIX. The path reaches the gate from the webview, as abinaryPathor a persisted pane param, before the host spawns it. The only side effect on POSIX is that a directory named literallya\..\bis refused, which no install produces.The new rejected cases in
lib/src/lib/agent-browser-binary.test.ts(/opt\..\x/agent-browser.exeand the Playwright twin) fail onmainand pass here. Theunc-binary-pathaudit canary is re-seeded over the moved lines, with its mutation unchanged, andscripts/security-audit-canary.test.mjspasses.