Repository navigation
Linux: call statx through syscall(2) so release builds link - #1106
Merged
Merged
Conversation
…glibc The v0.63.0 Linux ARM64 and x64 release builds failed to link with "undefined reference to statx". They build in cross images with a glibc older than 2.28, which has no statx wrapper, and the storage-cleanup mount check called libc::statx directly. syscall(2) needs no glibc symbol; a kernel without statx still refuses the repair. Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
issue_250_respawn_loop_converges_or_trips_without_false_readiness gave a freshly spawned test process 10 s to build a call graph and reach its barrier; a loaded macOS runner took longer. Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.63.0 Linux ARM64 and x64 release builds failed to link:
undefined reference to 'statx'frombash_background/persistence.rs(file_mount_identity, the storage-cleanup mount check). The release builds run incross0.2.5 images whose glibc predates 2.28, the first glibc with astatxwrapper. Regular CI doesn't build that way, so the break first showed at the tag. Nothing was published.The call now goes through
syscall(SYS_statx, ...), which needs no glibc symbol. A kernel without statx returns ENOSYS, which refuses the repair like any other mount boundary AFT can't verify.Verified: a
release.ymlvalidation run on this branch (run 40760225307, publishing off) built Linux ARM64 and Linux x64 successfully. Its CI-gate job fails by design, because branch runs have no main test run to point at.Summary by cubic
Fixes the v0.63.0 Linux ARM64 and x64 release builds, which failed to link with
undefined reference to 'statx'. The release builds link against a glibc older than 2.28, which has nostatxwrapper, so the storage-cleanup mount check now callsstatxthroughsyscall(2)instead; a kernel withoutstatxstill refuses the repair with ENOSYS. Also extends the callgraph respawn test's child-barrier wait from 10 s to 60 s, since a loaded macOS runner could exceed the old deadline. Nothing was published from the broken build.Written for commit 7f8ab5e. Summary will update on new commits.
Also carries a test-only fix:
issue_250_respawn_loop_converges_or_trips_without_false_readinessgave its child test process 10 s to reach a barrier. The test takes 12.5 s on main's macOS runners and failed at 10.7 s twice on this PR's macOS advisory runner. The wait is now 60 s.