Skip to content

Flake batch 20: eviction idle wait, startup-step deadline backstop, blob GC test budget - #1111

Merged
ualtinok merged 3 commits into
mainfrom
land/flake-batch-20
Oct 29, 2026
Merged

ualtinok merged 3 commits into
mainfrom
land/flake-batch-20

Conversation

@aft-alfonso

@aft-alfonso aft-alfonso Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

per_checkout_semantic_runtime::views_off_search_after_idle_eviction_reports_the_index_reloading failed on macOS in #1103's merge-queue group with "the root must be idle": it evicted once, right after readiness, while the root's background work was still finishing, and eviction refuses a root that isn't idle yet. It now retries eviction until it's accepted, within the file's 90 s deadline, the same way the views-on sibling test already waits for its lane. Test-only; the test passed 3 times on Linux, and the Windows target check passes.


Summary by cubic

Fixes three flaky tests on loaded CI runners where backstop deadlines fired before background work finished. The views-off eviction test now retries eviction until the root is idle, within the file's 90-second deadline. The startup-step deadline test widens its backstop window from 80 ms to 3 s so executor admission completes first. The blob GC batch test raises a test-only sweep budget from 5 s to 60 s so a loaded runner cannot cut it short. Test-only changes, plus the matching benchmark slice descriptor.

Written for commit 3e66a7d. Summary will update on new commits.

View guided diff Turn on auto-fix

ualtinok and others added 2 commits October 28, 2026 22:33
views_off_search_after_idle_eviction_reports_the_index_reloading evicted
once right after readiness and failed with "the root must be idle" on a
loaded macOS runner: eviction refuses a root whose background work is
still finishing. Retry until eviction accepts, within the file's deadline.

Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
The test fires the startup deadline itself once the stub holds the
sandbox profile step; the 80 ms window was only a backstop, but a loaded
macOS runner was still in executor admission when it expired, so the
refusal named admission instead of the held step. A 3 s backstop keeps
the test deterministic without making it slower.

Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
@ualtinok
ualtinok added this pull request to the merge queue Oct 28, 2026
@ualtinok
ualtinok removed this pull request from the merge queue due to a manual request Oct 28, 2026
@aft-alfonso aft-alfonso Bot changed the title Flake batch 20: views-off eviction test waits for an idle root Flake batch 20: views-off eviction waits for an idle root; startup-step deadline backstop outlasts admission Oct 28, 2026
@aft-alfonso

aft-alfonso Bot commented Oct 28, 2026

Copy link
Copy Markdown
Author

Added a second test-only fix: subc::bash::grant_path_tests::bash_deadline_warning_and_refusal_name_the_running_startup_step failed on macOS in #1108's queue group, because its refusal named executor admission. The test fires the startup deadline itself once the stub holds the sandbox profile step, and the 80 ms window is only a backstop, but a loaded runner was still admitting when it expired. The backstop is now 3 s, so the test isn't any slower. The deadline tests passed 3 times on Linux, plus the Windows target check.

…cut it short

The test checks that a sweep deletes its batch in one transaction, but it
ran through the production 5 s sweep budget, which a loaded Windows runner
overran on a three-row fixture ("blob sweep cancelled or deadline
reached"). A cfg(test) thread-local raises the budget for that test only.

Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
@aft-alfonso aft-alfonso Bot changed the title Flake batch 20: views-off eviction waits for an idle root; startup-step deadline backstop outlasts admission Flake batch 20: eviction idle wait, startup-step deadline backstop, blob GC test budget Oct 28, 2026
@aft-alfonso

aft-alfonso Bot commented Oct 28, 2026

Copy link
Copy Markdown
Author

Third test-only fix: gc::storage_retention_tests::blob_gc_deletes_a_bounded_batch_in_one_transaction knocked #1106 out of the merge queue on Windows with "blob sweep cancelled or deadline reached". It ran through the production 5 s sweep budget, which a loaded runner overran on a three-row fixture. A cfg(test) thread-local now raises the budget for that test only; production is unchanged. 31 gc tests passed 3 times on Linux, plus the Windows target check.

@ualtinok
ualtinok added this pull request to the merge queue Oct 28, 2026
Merged via the queue into main with commit bc12fb6 Oct 29, 2026
92 of 94 checks passed
@ualtinok
ualtinok deleted the land/flake-batch-20 branch October 29, 2026 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant