Repository navigation
Flake batch 20: eviction idle wait, startup-step deadline backstop, blob GC test budget - #1111
Conversation
views_off_search_after_idle_eviction_reports_the_index_reloading evicted once right after readiness and failed with "the root must be idle" on a loaded macOS runner: eviction refuses a root whose background work is still finishing. Retry until eviction accepts, within the file's deadline. Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
The test fires the startup deadline itself once the stub holds the sandbox profile step; the 80 ms window was only a backstop, but a loaded macOS runner was still in executor admission when it expired, so the refusal named admission instead of the held step. A 3 s backstop keeps the test deterministic without making it slower. Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
|
Added a second test-only fix: |
…cut it short
The test checks that a sweep deletes its batch in one transaction, but it
ran through the production 5 s sweep budget, which a loaded Windows runner
overran on a three-row fixture ("blob sweep cancelled or deadline
reached"). A cfg(test) thread-local raises the budget for that test only.
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
|
Third test-only fix: |
per_checkout_semantic_runtime::views_off_search_after_idle_eviction_reports_the_index_reloadingfailed on macOS in #1103's merge-queue group with "the root must be idle": it evicted once, right after readiness, while the root's background work was still finishing, and eviction refuses a root that isn't idle yet. It now retries eviction until it's accepted, within the file's 90 s deadline, the same way the views-on sibling test already waits for its lane. Test-only; the test passed 3 times on Linux, and the Windows target check passes.Summary by cubic
Fixes three flaky tests on loaded CI runners where backstop deadlines fired before background work finished. The views-off eviction test now retries eviction until the root is idle, within the file's 90-second deadline. The startup-step deadline test widens its backstop window from 80 ms to 3 s so executor admission completes first. The blob GC batch test raises a test-only sweep budget from 5 s to 60 s so a loaded runner cannot cut it short. Test-only changes, plus the matching benchmark slice descriptor.
Written for commit 3e66a7d. Summary will update on new commits.