pass exit code on format command#59
Open
jbolda wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: edb7fc4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
jbolda
changed the title
jbolda
force-pushed
the
format-pass-exit-code
branch
from
July 27, 2026 04:18
2cf4dc6 to
edb7fc4
Compare
gameroman
reviewed
Jul 27, 2026
| for await (const line of result) { | ||
| console.info(line); | ||
| } | ||
| if (result.exitCode !== 0) process.exit(result.exitCode!); |
Member
There was a problem hiding this comment.
maybe
Suggested change
| if (result.exitCode !== 0) process.exit(result.exitCode!); | |
| if (result.exitCode) process.exit(result.exitCode); |
Member
Author
There was a problem hiding this comment.
I thought about that, but it didn't feel appropriate to always call process.exit(). Don't love calling it either way, but kind of following precedenc.
Member
There was a problem hiding this comment.
This suggestions just removes non-null assertion, if result.exitCode is falsy, it still skips
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Passes through the exit code from the
formatcommand. Ifoxfmtfails, we will now recognize it (especially in CI).Type of change
Checklist
pnpm test)pnpm format)AI-generated code disclosure