Skip to content

fix(test): pass exit code on test command - #62

Open
dreyfus92 wants to merge 3 commits into
mainfrom
fix/test-exit-code
Open

dreyfus92 wants to merge 3 commits into
mainfrom
fix/test-exit-code

Conversation

@dreyfus92

Copy link
Copy Markdown
Member

bsh test prints vitest's output but never passes its exit code through, so ci stays green even when tests fail (bombshell-dev/clack#604 passed with 51 failed test files in its own log). same fix #59 and #60 did for format and lint.

added a test that runs bsh test against a fixture with a failing test and a passing one, it fails on main without the fix.

@changeset-bot

changeset-bot Bot commented Sep 15, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 10c9413

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bomb.sh/tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Sep 15, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@bomb.sh/tools@62

commit: 10c9413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants