Skip to content

pass exit code on format command #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jbolda wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −2
Open

pass exit code on format command #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/odd-coats-stick.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@bomb.sh/tools": patch
---

`format` CLI command respects internal format call and passes the exit code to the user.
5 changes: 3 additions & 2 deletions src/commands/format.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,10 @@ import { local } from '../utils.ts';
const config = fileURLToPath(new URL('../../oxfmtrc.json', import.meta.url));

export async function format(ctx: CommandContext) {
const stdio = x(local('oxfmt'), ['-c', config, ...ctx.args]);
const result = x(local('oxfmt'), ['-c', config, ...ctx.args]);

for await (const line of stdio) {
for await (const line of result) {
console.info(line);
}
if (result.exitCode !== 0) process.exit(result.exitCode!);

@gameroman gameroman Jul 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe

Suggested change
if (result.exitCode !== 0) process.exit(result.exitCode!);
if (result.exitCode) process.exit(result.exitCode);

@jbolda jbolda Jul 27, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that, but it didn't feel appropriate to always call process.exit(). Don't love calling it either way, but kind of following precedenc.

@gameroman gameroman Jul 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suggestions just removes non-null assertion, if result.exitCode is falsy, it still skips

}
Loading