Skip to content

Fix warnings due to changes on Unity 6.5 #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thomas-tu wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix warnings due to changes on Unity 6.5 #655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f230fcd
Fix warnings due to changes on Unity 6.5
thomas-tu Feb 25, 2026
c2c3a75
Update Changelog
thomas-tu Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
### Fixed

- [UUM-133861] Fixed "Look rotation viewing vector is zero" log being spammed when holding shift while using a create tool such as Create Sprite.
- Fixed warnings related to obsolete API calls with Unity 6.5.

## [6.0.9] - 2026-01-30

Expand Down
4 changes: 4 additions & 0 deletions Editor/EditorCore/EditorUtility.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,11 @@ public static void SetGizmoIconEnabled(Type script, bool enabled)

internal static T[] FindObjectsByType<T>() where T : UObject
{
#if UNITY_6000_5_OR_NEWER
Copy link

@windxu88 windxu88 Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems need to be UNITY_6000_4_OR_NEWER.
The deprecation happens starting from 6000.4,
see UnityEngineObject.bindings.cs at line 53 in 6000.4 branch.

return UObject.FindObjectsByType<T>();
#else
return UObject.FindObjectsByType<T>(FindObjectsSortMode.None);
#endif
}

internal static string GetActiveSceneAssetsPath()
Expand Down
4 changes: 3 additions & 1 deletion Tests/Editor/Editor/MeshSyncTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@ static ulong GetRawId(Object obj)
{
var id = obj.GetObjectId();

#if UNITY_6000_4_OR_NEWER
#if UNITY_6000_5_OR_NEWER
return EntityId.ToULong(id);
#elif UNITY_6000_4
return id.GetRawData();
#else
return (ulong)id;
Expand Down
9 changes: 8 additions & 1 deletion Tests/Editor/Undo/TestUndo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,19 @@ public static void CreateShape_UndoDoesRemoveTheGameObject()

instance.PerformAction();

#if UNITY_6000_5_OR_NEWER
Copy link

@windxu88 windxu88 Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same as above

var shapes = GameObject.FindObjectsByType<ProBuilderMesh>();
#else
var shapes = GameObject.FindObjectsByType<ProBuilderMesh>(FindObjectsSortMode.None);
#endif
Assume.That(shapes.Length, Is.EqualTo(1));

Undo.PerformUndo();

#if UNITY_6000_5_OR_NEWER
Copy link

@windxu88 windxu88 Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

shapes = GameObject.FindObjectsByType<ProBuilderMesh>();
#else
shapes = GameObject.FindObjectsByType<ProBuilderMesh>(FindObjectsSortMode.None);
#endif
Assert.That(shapes.Length, Is.EqualTo(0));
}

Expand Down