You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here are some key observations to aid the review process:
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
The PR contains straightforward preprocessor directive updates to accommodate Unity 6000.5 API changes.
🏅 Score: 100
The changes cleanly address the Unity 6.5 warnings using proper compiler directives, maintaining backward compatibility without introducing complexity.
🧪 PR contains tests
🔒 No security concerns identified
⚡ No major issues detected
Update review
🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr
The reason will be displayed to describe this comment to others. Learn more.
This seems need to be UNITY_6000_4_OR_NEWER.
The deprecation happens starting from 6000.4,
see UnityEngineObject.bindings.cs at line 53 in 6000.4 branch.
The reason will be displayed to describe this comment to others. Learn more.
Same here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT FORGET TO INCLUDE A CHANGELOG ENTRY
Purpose of this PR
This PR bring mandatory changes due to recent updates on U6.5.
[Brief summary of the changes in this PR.]
Links
Jira:
Comments to Reviewers
[List known issues, planned work, provide any extra context for your code.]