Repository navigation
fix(people): classify pending telegram admin removals - #94
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 43 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
lorenzocorallo
left a comment
There was a problem hiding this comment.
Technical review completed across Standards and Spec with independent review rounds. No outstanding actionable findings. Aligned the admin-removal discrepancy kind with the concurrent admin #97 update. New records store the kind, existing pending records are projected compatibly from their removal metadata, and self-service privacy remains scoped. Validation: 294 real-PostgreSQL tests, typecheck, Biome and server build pass; the regression includes legacy-kind compatibility and HR redaction. Live Microsoft 365, production SMTP and physical CIE hardware were outside this local validation. Administrative bypass of human approval is explicitly requested by the user.
Pending Telegram group removals must use the dashboard's dedicated
admin-removaldiscrepancy kind. Admin #97 gained that kind in a concurrent update after backend #83 merged; without alignment, My area cannot show its pending-removal notice and HR sees an irrelevant Linking action.New requests store the dedicated kind. The record projection also classifies existing pending records from their stored removal metadata, preserving compatibility with rows saved as
needs-review. Self-service users still see only their own pending removals, and unrelated HR discrepancies remain private.Validation: full suite with disposable PostgreSQL, 294 passed and 2 unrelated opt-in tests skipped; typecheck, Biome and server build pass. The red/green census regression covers the dedicated kind, legacy stored-kind compatibility, private-HR redaction and bot-confirmed completion.
Dependency for PoliNetworkOrg/admin#97 and #100. Follow-up to #83.