Skip to content

fix(people): classify pending telegram admin removals - #94

Merged
lorenzocorallo merged 1 commit into
mainfrom
fix/people-admin-removal-kind
Oct 22, 2026
Merged

lorenzocorallo merged 1 commit into
mainfrom
fix/people-admin-removal-kind

Conversation

@lorenzocorallo

Copy link
Copy Markdown
Member

Pending Telegram group removals must use the dashboard's dedicated admin-removal discrepancy kind. Admin #97 gained that kind in a concurrent update after backend #83 merged; without alignment, My area cannot show its pending-removal notice and HR sees an irrelevant Linking action.

New requests store the dedicated kind. The record projection also classifies existing pending records from their stored removal metadata, preserving compatibility with rows saved as needs-review. Self-service users still see only their own pending removals, and unrelated HR discrepancies remain private.

Validation: full suite with disposable PostgreSQL, 294 passed and 2 unrelated opt-in tests skipped; typecheck, Biome and server build pass. The red/green census regression covers the dedicated kind, legacy stored-kind compatibility, private-HR redaction and bot-confirmed completion.

Dependency for PoliNetworkOrg/admin#97 and #100. Follow-up to #83.

@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 43 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9a08d8f3-eb5b-4436-9f01-e775a97ac2a1
📥 Commits

Reviewing files that changed from the base of the PR and between 5b8f50e and 3f0bdfe.

📒 Files selected for processing: 4
  • src/people/contract.ts
  • src/people/model.ts
  • src/people/service.ts
  • tests/people.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lorenzocorallo lorenzocorallo left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical review completed across Standards and Spec with independent review rounds. No outstanding actionable findings. Aligned the admin-removal discrepancy kind with the concurrent admin #97 update. New records store the kind, existing pending records are projected compatibly from their removal metadata, and self-service privacy remains scoped. Validation: 294 real-PostgreSQL tests, typecheck, Biome and server build pass; the regression includes legacy-kind compatibility and HR redaction. Live Microsoft 365, production SMTP and physical CIE hardware were outside this local validation. Administrative bypass of human approval is explicitly requested by the user.

@lorenzocorallo
lorenzocorallo merged commit 18cffb7 into main Oct 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant