[viganogabriele]

Builds membership fee renewal and receipts on #97. Members upload bank-transfer receipts in My area; fee administrators review payments, remind members, retry delivery and void receipts; the assigned President/Vice-president signs.

• Receipt previews use eSign's PDF viewer and cancellation cleanup; the duplicate PdfPages implementation is removed.
• CIE signing uses the existing SignWithCie popup, job states and notifications. Manual ZIP download/signed-file upload remain available. Officers see only their signing actions; fee administrators and register readers get their own controls.
• Receipt requests in Signatures carry validated peopleReceipt provenance and link to the filtered receipt queue. Their placement is fixed, generic cancel/delete controls are hidden, and receipt signing still requires the dedicated permission.
• Unsigned mobile receipts name the expected signer. Copy and payment actions follow the fee state; a loaded transfer is reviewed rather than manually marked paid.

The People backend/receipt bridge is implemented in PoliNetworkOrg/backend#83 and must be merged and deployed first. people.receipts.prepareSignatures must return exactly the selected receipts with distinct durable request IDs. The backend owns officer/version checks, receipt/request association, both completion paths, retention and exactly-once email delivery without a browser callback. The matching contracts are in docs/people/contract.md and docs/esign/contracts.md; peopleReceipt is optional for deployed non-People eSign responses.

Permission matrix · Actual browser verification and limitations.

Validation: pnpm check, pnpm typecheck, pnpm test (90 passed, 3 optional integrations skipped) and pnpm build; 26 existing lint warnings. Browser checks cover the permission profiles at 320px and 1440px, the shared PDF preview, one fake fee approval, officer assignment, manual ZIP/options and the CIE backend-dependency error. Real CIE hardware, backend completion/delivery/concurrency and a real signed-in OIDC session were not verified. Signatures provenance was tested through its parser, not against a real eSign backend.

Merge audit, 22 October 2026

Inherited the latest #97 census follow-up. Backend #83 implements the People/receipt bridge and must be merged and deployed first. A receipt delivery retry now reports that delivery was retried and asks the user to check its status; it no longer claims successful email delivery when SMTP may have failed.

Validation: pnpm check, typecheck, test and build pass; 204 tests passed, 3 optional integrations skipped. Browser checks covered People pages at 1440px and 320px. Backend #83 PostgreSQL tests cover durable receipt completion and both signing paths. Real SMTP, Microsoft 365 and physical CIE hardware were not exercised.

The final backend contract includes PoliNetworkOrg/backend#94, which aligns the dedicated admin-removal kind with the concurrent dashboard update and preserves pending-state privacy. Both independent follow-up reviews approved the final alignment.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 45 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 20bba25d-7492-48d9-a332-d43ea80b3a90

📥 Commits

Reviewing files that changed from the base of the PR and between 99c2e8e and 8ea06aa.

📒 Files selected for processing: 49

• AGENTS.md
• README.md
• docs/design.md
• docs/esign/contracts.md
• docs/people/README.md
• docs/people/contract.md
• docs/people/decisions.md
• docs/people/fees.md
• docs/people/plan.md
• docs/people/verification.md
• src/components/shell/mobile-nav.tsx
• src/components/shell/nav.ts
• src/features/esign/batch-page.tsx
• src/features/esign/esign.functions.ts
• src/features/esign/pdf-viewer.tsx
• src/features/esign/receipt-request-link.tsx
• src/features/esign/receipt-source.ts
• src/features/esign/request-page.tsx
• src/features/esign/requests-page.tsx
• src/features/people/fee-dialogs.tsx
• src/features/people/member-dialogs.tsx
• src/features/people/members-page.tsx
• src/features/people/my-area-page.tsx
• src/features/people/my-fee-card.tsx
• src/features/people/people-fees.functions.ts
• src/features/people/people-fees.ts
• src/features/people/people-files.ts
• src/features/people/people-format.ts
• src/features/people/people-hooks.ts
• src/features/people/people-receipts.functions.ts
• src/features/people/people-self.functions.ts
• src/features/people/people.api.server.ts
• src/features/people/people.contract.ts
• src/features/people/people.fake.server.ts
• src/features/people/people.fixtures.server.ts
• src/features/people/person-page.tsx
• src/features/people/receipt-dialogs.tsx
• src/features/people/receipt-files.server.ts
• src/features/people/receipts-page.tsx
• src/lib/api/types.ts
• src/routeTree.gen.ts
• src/routes/dashboard.tsx
• src/routes/dashboard/people/receipts.tsx
• src/server/auth.middleware.ts
• src/server/permissions.ts
• tests/esign-pdf-lifecycle.test.mjs
• tests/people-esign.test.mjs
• tests/people-fees.test.mjs
• tests/server-security.test.mjs

Walkthrough

The PR adds People fee and receipt workflows, including member uploads, fee review and payment actions, receipt issuance, and officer signing tools. It adds contracts, server functions, a receipts route, agent-mode data, and shared UI controls. The production People backend bridge for receipt signing remains pending.

Changes

People fees and receipts

Layer / File(s)	Summary
Fee and receipt contracts and backend workflows src/features/people/people.contract.ts, src/features/people/people.api.server.ts, src/features/people/people.fake.server.ts, src/features/people/people.fixtures.server.ts, src/server/*, docs/people/*, tests/people-fees.test.mjs	The People data contract and server APIs now cover fees, receipts, permissions, member uploads, payment actions, and receipt handling. The fake API and fixtures implement and seed the workflows. Documentation describes the contract and marks the production signing bridge as pending.
Member fees and fee review src/features/people/members-page.tsx, src/features/people/person-page.tsx, src/features/people/my-fee-card.tsx, src/features/people/fee-dialogs.tsx, src/features/people/people-self.functions.ts	Member and person views now show fee data and expose receipt upload, fee review, payment, reminders, and receipt download actions. The dialogs handle receipt preview, approval or rejection, and manual payment.
Receipt queue and signing src/features/people/receipts-page.tsx, src/features/people/receipt-dialogs.tsx, src/routes/dashboard/people/receipts.tsx, src/components/shell/nav.ts, src/routes/dashboard.tsx, src/features/people/people-receipts.functions.ts, docs/esign/contracts.md, tests/people-esign.test.mjs	The Receipts route adds filtering, signing preparation, download and upload options, email retry, and void actions. Navigation shows the officer’s pending receipt count. Signing preparation calls the People API; the production backend bridge remains pending.
Shared UI controls and People page updates src/components/primitives/*, src/features/people/*, src/features/guides/guide-dialogs.tsx, src/features/azure/members-page.tsx, src/lib/date-only.ts, docs/design.md, tests/date-only.test.mjs	Shared controls now include date, file, filter, select, and radio-card components. People pages use shared loading, dialog, and action-menu patterns; academic-year labels now derive from the date. The design guidance and tests reflect these changes.

Sequence Diagram(s)

sequenceDiagram
  participant Member
  participant MyFeeCard
  participant uploadMyTransferReceipt
  participant PeopleApi
  participant PeopleBackend
  Member->>MyFeeCard: select transfer receipt, date, and amount
  MyFeeCard->>uploadMyTransferReceipt: submit transfer details and file
  uploadMyTransferReceipt->>PeopleApi: upload file and parsed transfer data
  PeopleApi->>PeopleBackend: forward transfer receipt request
  PeopleBackend-->>PeopleApi: upload result
  PeopleApi-->>uploadMyTransferReceipt: upload result
  uploadMyTransferReceipt-->>MyFeeCard: completion response
  MyFeeCard-->>Member: refresh fee view

Loading

Priority: ➖ Normal

Change: Feature

Merge Risk: 🔵 Low · up to 99c2e

The fee and receipt workflow is mergeable with small follow-ups. On mobile, a receipt still waiting for the other officer reads as already signed. Closing a PDF preview quickly can leave a background PDF worker running until the page reloads. Neither blocks the workflow.

Pre-merge checks: 3 · 1

Failed checks: 1 inconclusive

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 55.14% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 185 functions across 50 files. (15 skippe…	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 3 passed

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Title check		The title clearly summarizes the main changes: adding People fee renewal and signed-receipt workflows.

Full details: Docstring Coverage

Explanation

Docstring coverage is 55.14% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 185 functions across 50 files. (15 skipped: 9 unsupported, 6 over the file limit.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

✨ Finishing Touches: 💡 1

📝 Generate docstrings: 💡

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Diubii]

Ho fatto una passata su tutta l'area People (#97 + questa PR) seguendo le tue note: bug, ripetizioni, menu strani e controlli nativi del browser. Tutto in e289666; backend e auth non li ho toccati.

Bug

• "Add role" nella scheda persona poteva aprire un menu vuoto (solo people:members:write su una persona già socia). Ora con un solo ruolo disponibile è un pulsante semplice.
• Menu vuoti/strani nelle righe: nei Teams un Team Lead senza people:appoint apriva un ⋮ vuoto; nel registro soci il menu poteva iniziare con un separatore; "Review receipt" compariva per gli ex soci come icona ma non nel menu.
• todayIso() usava la data UTC: dopo mezzanotte le date di default (pagamento, bonifico, isExpired) erano del giorno prima. Ora usa la data locale (dateOnlyValue).
• Anno corrente scritto a mano (CURRENT_YEAR = "2026/27", "Open until 31 Oct 2026"): ora si calcola dalla data con currentYear(), con l'anno accademico che parte il 1° settembre. Se la regola è un'altra si cambia in un punto solo (academicYear in src/lib/date-only.ts, con test).
• Upload signed: il pulsante diceva "Add other files" ma sostituiva la lista → "Choose other files".
• My area mostrava "Signed " senza data; "Use @username" si poteva cliccare due volte; il fake salvava l'email personale vuota come "" invece di null.

Menu e controlli nativi

• Radio nativi (<input type="radio"> in 7 punti) → nuovi RadioCardGroup/RadioCard su Base UI, con nome accessibile e frecce.
• Anteprima PDF in Review receipt: niente più <iframe> (su Android non mostra nulla, su iOS solo la prima pagina). Le pagine sono disegnate con pdf.js (pdfjs-dist, caricato solo all'apertura del dialog).
• title= nativo → Hint; <input type="file"> scritto a mano → FilePickerButton (estratto da FileButton).
• Date picker: l'anno andava dal 1900 (137 voci) → ultimi 10 anni + il prossimo. DateField è ora un primitive e lo usa anche il dialog delle guide, che aveva una <select> nativa nascosta.
• Azioni di riga (ActionMenu): nessuna azione → slot vuoto, una sola → icona, due o più → ⋮ con le distruttive in fondo. Tolto "Open record" dai menu, perché la riga è già un link.
• Header: Export register è un'icona fissa accanto ad Add member (non più un ⋮ con una sola voce); il censimento ha Close campaign come icona.

Ripetizioni / TS

• errorMessage in people-hooks ora si appoggia a @/lib/errors e accetta qualsiasi errore: spariti ~33 caught instanceof Error ? … : …. I messaggi seguono "Couldn't {verb} {object}".
• useDialog/useDialogState + useOpenGeneration al posto dei 23 contatori setXKey(v => v + 1); useLoaded sostituisce 6 useEffect di caricamento identici; useFileDownload 3 handler di download; saveBlob sostituisce il download() dell'export (che revocava l'URL subito).
• SelectField, FilterMenu, ToggleFilter spostati nei primitive (il toggle era copiato da Microsoft 365 › Members, che ora lo usa).
• Stati del consenso foto in una tabella PHOTO_CONSENT invece di ternari ripetuti; plurali con pluralize.

Lasciato com'è

• PeopleApi resta definito tre volte (tipo, client, fake) su un client tRPC non tipizzato: va rifatto comunque quando il backend esporrà people.* nel router.

Docs aggiornate (docs/design.md, docs/people/*). pnpm check, typecheck, test (60/60) e build passano; provato in agent mode su desktop e mobile.

🤖 Generated with Claude Code

[lorenzocorallo]

Technical review completed across Standards and Spec with independent review rounds. No outstanding actionable findings. Verified fee permissions, officer selection, receipt/eSign provenance and the shared signing flow against backend #83. Receipt retry now reports an attempt without claiming SMTP success. Inherits the final #97 census/privacy fixes. Validation: check, typecheck, 204 tests and production build pass; 3 optional integrations skipped. Backend PostgreSQL tests cover durable signature completion and manual/CIE paths. Live Microsoft 365, production SMTP and physical CIE hardware were outside this local validation. Administrative bypass of human approval is explicitly requested by the user.