Skip to content

Move generic containers into core/containers#693

Draft
Spartan322 wants to merge 1 commit into
masterfrom
refactor/containers
Draft

Move generic containers into core/containers#693
Spartan322 wants to merge 1 commit into
masterfrom
refactor/containers

Conversation

@Spartan322

@Spartan322 Spartan322 commented Jan 21, 2026

Copy link
Copy Markdown
Member

Move tracked allocating containers to memory namespace

HasIdentifier.hpp will be split into distinct class headers after merge following #625, done to focus on changing the namespace and headers and minimize refactoring header inclusions in this PR.

@Spartan322 Spartan322 added enhancement Issue that describes an improvement to the project topic:codestyle Issue that applies stylistic changes to the module, semantics and mechanics should not change topic:core Issue that applies to core functions, fundamental to the rest of the module labels Jan 21, 2026
Move tracked allocating containers to memory namespace
Comment thread src/openvic-simulation/core/container/IndexedFlatMap.hpp
Comment thread src/openvic-simulation/core/container/IndexedFlatMap.hpp
wvpm
wvpm previously requested changes Jan 21, 2026

@wvpm wvpm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefixing commonly used types with memory:: hurts code.
If you want to bring your own allocator, you'd be better off using _detail::T<MyAllocator>

@wvpm

wvpm commented May 14, 2026

Copy link
Copy Markdown
Contributor

We could revive this. I am strongly in favour of splitting up Containers.hpp as it's leaking imports everywhere.
I still oppose prefixing commonly used types with memory::, especially if there is a variant without that prefix.

@wvpm wvpm mentioned this pull request May 14, 2026
@wvpm

wvpm commented May 19, 2026

Copy link
Copy Markdown
Contributor

Partially superseded by #731

@wvpm wvpm added the salvageable PR that needs to be fixed up for merge and which the author is leaving the PR dormant label May 19, 2026
@Spartan322
Spartan322 marked this pull request as draft May 19, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Issue that describes an improvement to the project salvageable PR that needs to be fixed up for merge and which the author is leaving the PR dormant topic:codestyle Issue that applies stylistic changes to the module, semantics and mechanics should not change topic:core Issue that applies to core functions, fundamental to the rest of the module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants