Skip to content

Split containers hpp#731

Merged
wvpm merged 1 commit into
masterfrom
split-containers-hpp
May 18, 2026
Merged

Split containers hpp#731
wvpm merged 1 commit into
masterfrom
split-containers-hpp

Conversation

@wvpm

@wvpm wvpm commented May 14, 2026 •
edited by Spartan322
Loading

Copy link
Copy Markdown
Contributor

Goal: reduce header imports leaking everywhere
Method: split up Containers.hpp into minimal headers and update consumers

@wvpm
wvpm requested a review from a team as a code owner May 14, 2026 13:06
@wvpm wvpm added enhancement Issue that describes an improvement to the project topic:core Issue that applies to core functions, fundamental to the rest of the module topic:codestyle Issue that applies stylistic changes to the module, semantics and mechanics should not change labels May 14, 2026
@wvpm
wvpm force-pushed the split-containers-hpp branch 2 times, most recently from 5ab1243 to a06fb48 Compare May 14, 2026 13:26
@wvpm
wvpm marked this pull request as draft May 14, 2026 13:45
@wvpm
wvpm changed the base branch from master to minimise_fp_header May 14, 2026 13:48
@wvpm
wvpm force-pushed the split-containers-hpp branch from a06fb48 to 53584d4 Compare May 14, 2026 18:19
@wvpm
wvpm force-pushed the minimise_fp_header branch from 219a80d to 3f32a55 Compare May 14, 2026 23:08
@wvpm
wvpm force-pushed the split-containers-hpp branch 2 times, most recently from 6130c5a to 73b5eb3 Compare May 14, 2026 23:18
@wvpm
wvpm force-pushed the minimise_fp_header branch 6 times, most recently from 2674f03 to f3a283b Compare May 17, 2026 11:20
Base automatically changed from minimise_fp_header to master May 17, 2026 11:34
@wvpm
wvpm force-pushed the split-containers-hpp branch from 73b5eb3 to c3b20a2 Compare May 17, 2026 11:47
@wvpm
wvpm marked this pull request as ready for review May 17, 2026 11:47
@wvpm
wvpm enabled auto-merge May 17, 2026 11:57
@wvpm
wvpm disabled auto-merge May 17, 2026 11:57
@wvpm
wvpm force-pushed the split-containers-hpp branch from c3b20a2 to 5f1d368 Compare May 17, 2026 11:59
@wvpm
wvpm enabled auto-merge May 17, 2026 11:59
Spartan322
Spartan322 reviewed May 18, 2026
View reviewed changes
Comment thread src/openvic-simulation/core/memory/allocators/Deleter.hpp Outdated
Spartan322
Spartan322 reviewed May 18, 2026
View reviewed changes
Comment thread src/openvic-simulation/core/memory/allocators/NewAllocator.hpp Outdated
Spartan322
Spartan322 reviewed May 18, 2026
View reviewed changes
Comment thread src/openvic-simulation/core/memory/Colony.hpp Outdated
Spartan322
Spartan322 reviewed May 18, 2026
View reviewed changes
Comment thread src/openvic-simulation/core/memory/CowPtr.hpp Outdated
Spartan322
Spartan322 reviewed May 18, 2026
View reviewed changes
Comment thread src/openvic-simulation/core/memory/CowVector.hpp Outdated
Spartan322
Spartan322 reviewed May 18, 2026
View reviewed changes
Comment thread src/openvic-simulation/core/memory/Deque.hpp Outdated
Spartan322
Spartan322 reviewed May 18, 2026
View reviewed changes
Comment thread src/openvic-simulation/core/memory/Formatting.hpp Outdated
Spartan322
Spartan322 reviewed May 18, 2026
View reviewed changes
Comment thread src/openvic-simulation/core/memory/Formatting.hpp Outdated
Spartan322
Spartan322 reviewed May 18, 2026
View reviewed changes
Comment thread src/openvic-simulation/core/memory/make_tracked_allocator.hpp Outdated
Spartan322
Spartan322 reviewed May 18, 2026
View reviewed changes
Comment thread src/openvic-simulation/core/memory/Queue.hpp Outdated
Spartan322
Spartan322 reviewed May 18, 2026
View reviewed changes
Comment thread src/openvic-simulation/core/memory/SmartPtr.hpp Outdated
Spartan322
Spartan322 reviewed May 18, 2026
View reviewed changes
Comment thread src/openvic-simulation/core/memory/SmartPtr.hpp Outdated
Spartan322
Spartan322 reviewed May 18, 2026
View reviewed changes
Comment thread src/openvic-simulation/core/memory/String.hpp Outdated
Spartan322
Spartan322 reviewed May 18, 2026
View reviewed changes
Comment thread src/openvic-simulation/core/memory/StringStream.hpp Outdated
Spartan322
Spartan322 reviewed May 18, 2026
View reviewed changes
Comment thread src/openvic-simulation/core/memory/Vector.hpp Outdated
Spartan322
Spartan322 reviewed May 18, 2026
View reviewed changes
Comment thread src/openvic-simulation/types/Signal.hpp
@wvpm
wvpm force-pushed the split-containers-hpp branch 2 times, most recently from bead4a0 to 93ed86c Compare May 18, 2026 11:14
Spartan322
Spartan322 reviewed May 18, 2026
View reviewed changes
Comment thread src/openvic-simulation/core/memory/CowVector.hpp Outdated
@wvpm
wvpm force-pushed the split-containers-hpp branch from 93ed86c to c047918 Compare May 18, 2026 12:39
Spartan322
Spartan322 reviewed May 18, 2026
View reviewed changes
Comment thread src/openvic-simulation/console/ConsoleInstance.cpp Outdated
Spartan322
Spartan322 reviewed May 18, 2026
View reviewed changes
Comment thread src/openvic-simulation/GameManager.cpp Outdated
@wvpm
wvpm force-pushed the split-containers-hpp branch from c047918 to caf1082 Compare May 18, 2026 14:02
@wvpm
wvpm merged commit bbdafc0 into master May 18, 2026
16 checks passed
@wvpm
wvpm deleted the split-containers-hpp branch May 18, 2026 14:25
@wvpm wvpm mentioned this pull request May 19, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Spartan322 Spartan322 Spartan322 approved these changes

Assignees

No one assigned

Labels

enhancement Issue that describes an improvement to the project topic:codestyle Issue that applies stylistic changes to the module, semantics and mechanics should not change topic:core Issue that applies to core functions, fundamental to the rest of the module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wvpm @Spartan322