Move STL-like container headers to `core/stl/containers` by Spartan322 · Pull Request #744 · OpenVicProject/OpenVic-Simulation

Spartan322 · 2026-05-20T06:05:56Z

Partially supersedes Move generic containers into core/containers #693

Includes:

CowPtr
CowVector
FixedVector
RingBuffer
StackString
TypedSpan

Move allocator aware STL-like containers to OpenVic::stl namespace
Includes:

CowPtr
CowVector
FixedVector
RingBuffer

Move BasicIterator to core/stl
Move TslHelper.hpp to core/stl and rename to MutableIterator.hpp

Move memory container type aliases to core/memory

Add memory type alias for cow_ptr
Add memory type alias for cow_vector

Move FixedVector from namespace OpenVic::_detail to OpenVic::stl

Add stateful allocator support to FixedVector's constructors

Replace assert in TypedSpan with OV_HARDEN_ASSERT_ACCESS

Move STL-like container unit tests to core/stl/containers

wvpm

Overall a step in the right direction.
Move tunable_vector to a separate PR. It has nothing to do with this.
Besides that, it just need some import fixes.

wvpm

Support constructor tags in FixedVector and this is ready for merge 👍

wvpm

The FixedVector now has a critical bug with size. See comments

Includes: - CowPtr - CowVector - FixedVector - RingBuffer - StackString - TypedSpan Move allocator aware STL-like containers to `OpenVic::stl` namespace Includes: - CowPtr - CowVector - FixedVector - RingBuffer Move BasicIterator to `core/stl` Move TslHelper.hpp to `core/stl` and rename to MutableIterator.hpp Move memory container type aliases to `core/memory` Add memory type alias for cow_ptr Add memory type alias for cow_vector Move FixedVector from namespace `OpenVic::_detail` to `OpenVic::stl` Add stateful allocator support to FixedVector's constructors Replace assert in TypedSpan with `OV_HARDEN_ASSERT_ACCESS` Move STL-like container unit tests to `core/stl/containers`

Spartan322 requested a review from a team as a code owner May 20, 2026 06:05

Spartan322 added enhancement Issue that describes an improvement to the project topic:codestyle Issue that applies stylistic changes to the module, semantics and mechanics should not change topic:core Issue that applies to core functions, fundamental to the rest of the module labels May 20, 2026

Spartan322 force-pushed the add/stl-like-containers branch 2 times, most recently from 45f5685 to 6fd5c56 Compare May 20, 2026 06:11

wvpm reviewed May 20, 2026

View reviewed changes

Comment thread src/openvic-simulation/core/memory/CowPtr.hpp Outdated

wvpm reviewed May 20, 2026

View reviewed changes

Comment thread src/openvic-simulation/core/memory/FixedVector.hpp

wvpm reviewed May 20, 2026

View reviewed changes

Comment thread src/openvic-simulation/core/memory/RingBuffer.hpp

wvpm reviewed May 20, 2026

View reviewed changes

Comment thread src/openvic-simulation/core/stl/containers/TunableVector.hpp Outdated

wvpm reviewed May 20, 2026

View reviewed changes

Comment thread src/openvic-simulation/core/memory/TunableVector.hpp Outdated

wvpm reviewed May 20, 2026

View reviewed changes

Comment thread src/openvic-simulation/core/portable/ForwardableSpan.hpp

wvpm reviewed May 20, 2026

View reviewed changes

Comment thread src/openvic-simulation/core/stl/containers/CowVector.hpp

wvpm reviewed May 20, 2026

View reviewed changes

Comment thread src/openvic-simulation/core/stl/containers/FixedVector.hpp Outdated

wvpm reviewed May 20, 2026

View reviewed changes

Comment thread src/openvic-simulation/core/stl/containers/TypedSpan.hpp Outdated

wvpm reviewed May 20, 2026

View reviewed changes

Comment thread src/openvic-simulation/core/stl/containers/TypedSpan.hpp

wvpm reviewed May 20, 2026

View reviewed changes

Comment thread src/openvic-simulation/types/Signal.hpp

wvpm reviewed May 20, 2026

View reviewed changes

Comment thread tests/src/core/stl/containers/FixedVector.cpp

wvpm requested changes May 20, 2026

View reviewed changes

Spartan322 force-pushed the add/stl-like-containers branch from 6fd5c56 to b3f4817 Compare May 20, 2026 11:20

Spartan322 mentioned this pull request May 20, 2026

Add missing dependencies to IncludeCategories #745

Merged

Spartan322 force-pushed the add/stl-like-containers branch 2 times, most recently from bdb5122 to 0c289ed Compare May 20, 2026 16:25

Spartan322 mentioned this pull request May 20, 2026

Add tunable_vector std::vector wrapper container #746

Draft

Spartan322 requested a review from wvpm May 20, 2026 16:28

Spartan322 force-pushed the add/stl-like-containers branch from 0c289ed to b2c561e Compare May 20, 2026 16:39

wvpm reviewed May 20, 2026

View reviewed changes

Comment thread src/openvic-simulation/core/stl/containers/FixedVector.hpp Outdated

wvpm previously approved these changes May 20, 2026

View reviewed changes

Spartan322 dismissed wvpm’s stale review via bef38da May 20, 2026 19:45

Spartan322 force-pushed the add/stl-like-containers branch from b2c561e to bef38da Compare May 20, 2026 19:45

Spartan322 force-pushed the add/stl-like-containers branch 2 times, most recently from d4bc84c to db3fe7f Compare May 20, 2026 20:14

wvpm reviewed May 20, 2026

View reviewed changes

Comment thread src/openvic-simulation/core/stl/containers/FixedVector.hpp Outdated

wvpm reviewed May 20, 2026

View reviewed changes

Comment thread src/openvic-simulation/core/stl/containers/FixedVector.hpp Outdated

wvpm reviewed May 20, 2026

View reviewed changes

Comment thread src/openvic-simulation/core/stl/containers/FixedVector.hpp

wvpm requested changes May 20, 2026

View reviewed changes

Spartan322 force-pushed the add/stl-like-containers branch 2 times, most recently from f94003a to 069ae75 Compare May 21, 2026 00:48

Spartan322 requested a review from wvpm May 21, 2026 00:48

Spartan322 force-pushed the add/stl-like-containers branch 2 times, most recently from ecb7ae0 to b8ffe2c Compare May 21, 2026 04:30

wvpm reviewed May 21, 2026

View reviewed changes

Comment thread src/openvic-simulation/economy/production/ResourceGatheringOperation.hpp Outdated

wvpm previously approved these changes May 21, 2026

View reviewed changes

wvpm reviewed May 21, 2026

View reviewed changes

Comment thread src/openvic-simulation/core/stl/containers/FixedVector.hpp Outdated

wvpm reviewed May 21, 2026

View reviewed changes

Comment thread src/openvic-simulation/core/stl/containers/FixedVector.hpp Outdated

Spartan322 dismissed wvpm’s stale review via 8606610 May 23, 2026 22:37

Spartan322 force-pushed the add/stl-like-containers branch from b8ffe2c to 8606610 Compare May 23, 2026 22:37

Spartan322 requested a review from wvpm May 23, 2026 22:38

wvpm approved these changes May 23, 2026

View reviewed changes

Spartan322 force-pushed the add/stl-like-containers branch from 8606610 to fa0e42f Compare May 23, 2026 23:08

Spartan322 enabled auto-merge May 23, 2026 23:08

Spartan322 merged commit 74077cd into master May 23, 2026
16 checks passed

wvpm deleted the add/stl-like-containers branch May 23, 2026 23:14

Uh oh!

Conversation

Spartan322 commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wvpm left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wvpm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wvpm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Spartan322 commented May 20, 2026 •

edited

Loading

wvpm left a comment •

edited

Loading